Fix column tooltip not repositioning correctly when resizing columns#534
Merged
mofojed merged 1 commit intodeephaven:mainfrom May 2, 2022
Merged
Conversation
- When the column is resized, we were updating props but not calling tooltip.update() to update the existing tooltip - Needed to bring the getBoundingClientRect method out of the in line definition - before, even after getting called again, it was just using the old values (what the values were when the function was created). Pulled the latest metrics from `this` and then it's good. - Side note: Because of the order of mouse handlers, the tooltip mouse handler doesn't get an event on click; it's eaten by GridColumnSeparatorMouseHandler. We don't really want to change the order of those mouse handlers, as the tooltip should be a low priority thing (i.e. we don't want to tooltip appearing when hovering over the column separator), so did not adjust the ordering. - Fixes deephaven#510
Codecov Report
@@ Coverage Diff @@
## main #534 +/- ##
==========================================
- Coverage 36.38% 36.38% -0.01%
==========================================
Files 390 390
Lines 28503 28509 +6
Branches 6730 6730
==========================================
+ Hits 10371 10372 +1
- Misses 17786 17791 +5
Partials 346 346
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mattrunyon
approved these changes
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thisand then it's good.