Skip to content

DH-10111 Fix missing horizontal scroll bar for single column tables#543

Merged
mofojed merged 7 commits intodeephaven:mainfrom
mattrunyon:mattrunyon_446
May 6, 2022
Merged

DH-10111 Fix missing horizontal scroll bar for single column tables#543
mofojed merged 7 commits intodeephaven:mainfrom
mattrunyon:mattrunyon_446

Conversation

@mattrunyon
Copy link
Collaborator

Fixes #446 and related to DH-10111 test failure

This adds a horizontal scroll bar for any single column table which does not fit in the panel fully

Example Python to test with

from deephaven import new_table
from deephaven.column import string_col
import random
import string

letters = string.printable
strings = [''.join(random.choice(letters) for i in range(random.randint(0, 1000))) for j in range(0, 100)]
table1 = new_table([string_col("Random", strings)])

Also tested with changing IrisGridTheme.rowHeaderWidth to be non-zero

@mattrunyon mattrunyon added the bug Something isn't working label Apr 29, 2022
@mattrunyon mattrunyon requested a review from mofojed April 29, 2022 23:15
@mattrunyon mattrunyon self-assigned this Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #543 (0a2e183) into main (b24ade4) will decrease coverage by 0.01%.
The diff coverage is 39.81%.

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
- Coverage   36.38%   36.36%   -0.02%     
==========================================
  Files         390      390              
  Lines       28511    28562      +51     
  Branches     6731     6764      +33     
==========================================
+ Hits        10374    10387      +13     
- Misses      17791    17829      +38     
  Partials      346      346              
Flag Coverage Δ
unit 36.36% <39.81%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/grid/src/Grid.tsx 64.50% <0.00%> (-2.07%) ⬇️
...se-handlers/GridHorizontalScrollBarMouseHandler.ts 34.66% <40.00%> (-2.48%) ⬇️
...ouse-handlers/GridVerticalScrollBarMouseHandler.ts 34.66% <40.00%> (-2.48%) ⬇️
packages/grid/src/GridMetricCalculator.ts 75.39% <87.09%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24ade4...0a2e183. Read the comment docs.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shift+Wheel (which should scroll horizontally) isn't working. I think need to update Grid.tsx handleWheel function

@mattrunyon mattrunyon requested a review from mofojed May 3, 2022 20:50
@mattrunyon
Copy link
Collaborator Author

Updated so vertical scroll uses the same logic as horizontal

Tested by setting a big rowHeight in IrisGridTheme.module.scss. Also fixed/tested horizontal scroll with scrollSnapToColumn: true in IrisGridTheme.ts

@mofojed mofojed merged commit 1233afa into deephaven:main May 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
@mattrunyon mattrunyon deleted the mattrunyon_446 branch June 23, 2024 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Horizontal scroll never appears for single column table

2 participants