Skip to content

Fix cell overflow button overlapping scroll bar and not truncating text with row header#544

Merged
mofojed merged 1 commit intodeephaven:mainfrom
mattrunyon:overflow-button-fixes
May 2, 2022
Merged

Fix cell overflow button overlapping scroll bar and not truncating text with row header#544
mofojed merged 1 commit intodeephaven:mainfrom
mattrunyon:overflow-button-fixes

Conversation

@mattrunyon
Copy link
Collaborator

This fixes 2 small issues with the cell overflow button.

  1. Cell overflow button was overlapping the horizontal scroll bar. Now it draws under the scroll bar. It should still show even if the scroll bar partially covers a row because you can have the row covered by 1-2 pixels and you will see all content in the cell still. The overflow not appearing because the border is overlapped by the scroll bar could be frustrating to a user.
  2. Cells were not truncating properly when IrisGridTheme.rowHeaderWidth was non-zero. The header width was not accounted for

@mattrunyon mattrunyon added the bug Something isn't working label Apr 29, 2022
@mattrunyon mattrunyon requested a review from mofojed April 29, 2022 23:21
@mattrunyon mattrunyon self-assigned this Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #544 (967bf61) into main (ac30f27) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   36.38%   36.39%           
=======================================
  Files         390      390           
  Lines       28503    28505    +2     
  Branches     6731     6731           
=======================================
+ Hits        10371    10373    +2     
  Misses      17786    17786           
  Partials      346      346           
Flag Coverage Δ
unit 36.39% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/iris-grid/src/IrisGridRenderer.js 24.31% <75.00%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac30f27...967bf61. Read the comment docs.

@mofojed mofojed linked an issue May 2, 2022 that may be closed by this pull request
@mofojed mofojed merged commit b24ade4 into deephaven:main May 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2022
@mattrunyon mattrunyon deleted the overflow-button-fixes branch June 23, 2024 06:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cell overflow rendering on top of scroll bar

2 participants