Fix cell overflow button overlapping scroll bar and not truncating text with row header#544
Merged
mofojed merged 1 commit intodeephaven:mainfrom May 2, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #544 +/- ##
=======================================
Coverage 36.38% 36.39%
=======================================
Files 390 390
Lines 28503 28505 +2
Branches 6731 6731
=======================================
+ Hits 10371 10373 +2
Misses 17786 17786
Partials 346 346
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mofojed
approved these changes
May 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes 2 small issues with the cell overflow button.
IrisGridTheme.rowHeaderWidthwas non-zero. The header width was not accounted for