Replace anonymous useEffect functions with named functions

[Zhou-Ziheng]

Fixes #532

[mofojed]

Your tests are failing because of an eslint rule prefer-arrow-callback. You can disable that rule in our eslint config:

web-client-ui/packages/eslint-config/index.js

Line 77 in a34ba2c

'no-useless-constructor': 'off',

Just add a 'prefer-arrow-callback': 'off' line there with a comment

[codecov]

Codecov Report

Merging #553 (2eb5700) into main (a1f25a6) will increase coverage by 0.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   36.37%   36.43%   +0.06%     
==========================================
  Files         390      390              
  Lines       28577    28642      +65     
  Branches     6774     6777       +3     
==========================================
+ Hits        10394    10436      +42     
- Misses      17837    17860      +23     
  Partials      346      346              

Flag	Coverage Δ
unit	36.43% <50.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/code-studio/src/main/AppControlsMenu.jsx	11.47% <0.00%> (-0.20%)	⬇️
packages/code-studio/src/main/AppInit.jsx	0.00% <0.00%> (ø)
packages/code-studio/src/settings/ShortcutItem.tsx	0.00% <0.00%> (ø)
packages/components/src/AutoResizeTextarea.tsx	0.00% <0.00%> (ø)
packages/components/src/CardFlip.tsx	0.00% <0.00%> (ø)
packages/components/src/Checkbox.tsx	0.00% <0.00%> (ø)
packages/file-explorer/src/FileExplorer.tsx	0.00% <0.00%> (ø)
packages/file-explorer/src/FileList.tsx	10.09% <0.00%> (-0.15%)	⬇️
packages/file-explorer/src/FileListItemEditor.tsx	0.00% <0.00%> (ø)
...ebar/conditional-formatting/ColumnFormatEditor.tsx	5.88% <0.00%> (-0.12%)	⬇️
... and 26 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f25a6...2eb5700. Read the comment docs.

[mattrunyon]

Should probably change the eslint rule to just allowNamedFunctions instead of removing it entirely. Still prefer arrows over unnamed functions

https://eslint.org/docs/rules/prefer-arrow-callback#allownamedfunctions

[mofojed]

Rebase off the latest main as well. Let me know if you need help stepping through that.

[mofojed]

Suggested change

	function updateViewportAndReturnClaenup() {
	function updateViewportAndReturnCleanup() {

[mofojed]

Still need to update the typo in StorageTableViewportUpdater