Skip to content

remove enzyme from components#568

Merged
Zhou-Ziheng merged 8 commits intodeephaven:mainfrom
Zhou-Ziheng:563-remove-enzyme-from-components
May 16, 2022
Merged

remove enzyme from components#568
Zhou-Ziheng merged 8 commits intodeephaven:mainfrom
Zhou-Ziheng:563-remove-enzyme-from-components

Conversation

@Zhou-Ziheng
Copy link
Contributor

Fixes #563

@Zhou-Ziheng Zhou-Ziheng requested a review from mofojed May 11, 2022 21:40
@Zhou-Ziheng Zhou-Ziheng self-assigned this May 11, 2022
@Zhou-Ziheng Zhou-Ziheng added the enhancement New feature or request label May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #568 (22f4be9) into main (7418086) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   36.68%   36.84%   +0.15%     
==========================================
  Files         390      390              
  Lines       28655    28659       +4     
  Branches     6775     6778       +3     
==========================================
+ Hits        10513    10558      +45     
+ Misses      17796    17755      -41     
  Partials      346      346              
Flag Coverage Δ
unit 36.84% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nditional-formatting/ConditionalFormattingUtils.ts 26.26% <0.00%> (+0.75%) ⬆️
packages/components/src/MaskedInput.tsx 75.12% <0.00%> (+2.07%) ⬆️
packages/components/src/TimeInput.tsx 76.59% <0.00%> (+2.12%) ⬆️
...components/src/context-actions/ContextMenuItem.tsx 65.30% <0.00%> (+4.08%) ⬆️
packages/components/src/ItemList.tsx 75.50% <0.00%> (+7.04%) ⬆️
packages/components/src/ItemListItem.tsx 59.74% <0.00%> (+16.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7418086...22f4be9. Read the comment docs.

@Zhou-Ziheng Zhou-Ziheng requested a review from mofojed May 12, 2022 22:12
@mofojed mofojed added internal and removed enhancement New feature or request labels May 16, 2022
@Zhou-Ziheng Zhou-Ziheng merged commit 5bd90ce into deephaven:main May 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Enzyme from components (ComboBox, ItemList, MaskedInput, RadioGroup, TimeInput, TimeSlider, ContextMenuItem)

2 participants