Fix invalid format custom columns created from row formats based on different columns#569
Merged
vbabich merged 2 commits intodeephaven:mainfrom May 12, 2022
Merged
Conversation
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
Codecov Report
@@ Coverage Diff @@
## main #569 +/- ##
=======================================
Coverage 36.68% 36.69%
=======================================
Files 390 390
Lines 28655 28659 +4
Branches 6775 6778 +3
=======================================
+ Hits 10513 10517 +4
Misses 17796 17796
Partials 346 346
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mofojed
previously approved these changes
May 12, 2022
packages/iris-grid/src/sidebar/conditional-formatting/ConditionalFormattingUtils.ts
Outdated
Show resolved
Hide resolved
…nalFormattingUtils.ts Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
May 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying custom columns with more than one row format column crashes the grid panel. Fixed by stacking all row formats into a single rule. Added unit test.