Skip to content

Don't scroll columns into view on click#571

Merged
dsmmcken merged 1 commit intomainfrom
dmckenzie_567
May 12, 2022
Merged

Don't scroll columns into view on click#571
dsmmcken merged 1 commit intomainfrom
dmckenzie_567

Conversation

@dsmmcken
Copy link
Contributor

Fixes Click to focus column is more annoying than useful #567

Fixes Click to focus column is more annoying than useful #567
@dsmmcken dsmmcken requested a review from mofojed May 12, 2022 15:15
@dsmmcken dsmmcken added enhancement New feature or request grid package/grid labels May 12, 2022
@mattrunyon mattrunyon linked an issue May 12, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #571 (dcd122c) into main (7418086) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   36.68%   36.68%           
=======================================
  Files         390      390           
  Lines       28655    28655           
  Branches     6775     6775           
=======================================
  Hits        10513    10513           
  Misses      17796    17796           
  Partials      346      346           
Flag Coverage Δ
unit 36.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...id/src/mouse-handlers/GridSelectionMouseHandler.ts 62.23% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7418086...dcd122c. Read the comment docs.

@dsmmcken dsmmcken merged commit 971bcd7 into main May 12, 2022
@dsmmcken dsmmcken deleted the dmckenzie_567 branch May 12, 2022 21:04
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request grid package/grid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Click to scroll column into view is more annoying than useful

2 participants