Skip to content

Use session type provided by the server instead of hardcoding python#574

Merged
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:573-embed-groovy
May 12, 2022
Merged

Use session type provided by the server instead of hardcoding python#574
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:573-embed-groovy

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented May 12, 2022

Now you can embed grids from Groovy sessions as well

Fixes #573

Now you can embed grids from Groovy sessions as well

Fixes deephaven#573
@mofojed mofojed added the bug Something isn't working label May 12, 2022
@mofojed mofojed added this to the May 2022 milestone May 12, 2022
@mofojed mofojed requested a review from vbabich May 12, 2022 18:33
@mofojed mofojed self-assigned this May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #574 (019dc3a) into main (7418086) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   36.68%   36.68%           
=======================================
  Files         390      390           
  Lines       28655    28655           
  Branches     6775     6775           
=======================================
  Hits        10513    10513           
  Misses      17796    17796           
  Partials      346      346           
Flag Coverage Δ
unit 36.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7418086...019dc3a. Read the comment docs.

Copy link
Collaborator

@vbabich vbabich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Session type could be also selectable via url params

@dsmmcken
Copy link
Contributor

Session type could be also selectable via url params

url params can't set the session type though, so I don't see a point to doing it that way.

@mofojed
Copy link
Member Author

mofojed commented May 12, 2022

I mean aside from the point that for this grid it's language agnostic and doesn't care if it's python OR groovy. Would rather there was some way to connect and get a table without specifying a language if you're not going to be running commands.

@mofojed mofojed merged commit 31f4bc8 into deephaven:main May 12, 2022
@mofojed mofojed deleted the 573-embed-groovy branch May 12, 2022 20:34
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow iframes to work with groovy

3 participants