Skip to content

BREAKING: Clean up iris-grid dependencies#576

Merged
mofojed merged 4 commits intodeephaven:mainfrom
mofojed:549-clean-up-iris-grid
May 20, 2022
Merged

BREAKING: Clean up iris-grid dependencies#576
mofojed merged 4 commits intodeephaven:mainfrom
mofojed:549-clean-up-iris-grid

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented May 12, 2022

  • Move formatters, DateUtils, and TableUtils out from iris-grid into @deephaven/jsapi-utils
  • Move Filter type definitions to @deephaven/filters
  • No more iris-grid/dist imports
  • @deephaven/chart no longer depends on @deephaven/iris-grid
  • Fixes Remove chart dependency on iris-grid #549

- Move formatters, DateUtils, and TableUtils out from iris-grid into @deephaven/jsapi-utils
- Move Filter type definitions to @deephaven/filters
- No more `iris-grid/dist` imports
- @deephaven/chart no longer depends on @deephaven/iris-grid
- Fixes 549
@mofojed mofojed added this to the May 2022 milestone May 12, 2022
@mofojed mofojed requested review from mattrunyon and vbabich May 12, 2022 21:12
@mofojed mofojed self-assigned this May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #576 (115262a) into main (08effea) will decrease coverage by 0.28%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   36.78%   36.50%   -0.29%     
==========================================
  Files         390      390              
  Lines       28678    28613      -65     
  Branches     6777     6745      -32     
==========================================
- Hits        10549    10444     -105     
- Misses      17787    17827      +40     
  Partials      342      342              
Flag Coverage Δ
unit 36.50% <42.85%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/chart/src/Chart.jsx 0.00% <ø> (ø)
packages/chart/src/ChartUtils.js 63.06% <ø> (+0.18%) ⬆️
packages/code-studio/src/main/AppInit.jsx 0.00% <ø> (ø)
...e-studio/src/settings/FormattingSectionContent.jsx 39.02% <ø> (ø)
...s/code-studio/src/storage/LocalWorkspaceStorage.ts 13.33% <ø> (ø)
...ode-studio/src/storage/PouchCommandHistoryTable.ts 0.00% <ø> (ø)
...kages/code-studio/src/storage/PouchStorageTable.ts 0.00% <ø> (ø)
packages/code-studio/src/styleguide/Grids.jsx 100.00% <ø> (ø)
...ode-studio/src/styleguide/MockIrisGridTreeModel.ts 34.45% <ø> (ø)
...ns/src/controls/dropdown-filter/DropdownFilter.jsx 4.26% <ø> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08effea...115262a. Read the comment docs.

"react": "^17.0.0"
},
"devDependencies": {
"@deephaven/filters": "file:../filters",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file path is fine for dev deps though. Since you would have the entire monorepo downloaded for development, but not for installing as a normal dep in a project

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my above comment - it is fine for devDependencies and dependencies, does not appear to be fine for peerDependencies (which we should probably remove from most of our packages anyway.

@mofojed mofojed requested a review from mattrunyon May 18, 2022 12:33
vbabich
vbabich previously approved these changes May 20, 2022
@mofojed mofojed dismissed mattrunyon’s stale review May 20, 2022 19:40

Addressed review comments

@mofojed mofojed merged commit 67c02cb into deephaven:main May 20, 2022
@mofojed mofojed deleted the 549-clean-up-iris-grid branch May 20, 2022 19:45
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove chart dependency on iris-grid

3 participants