BREAKING: Clean up iris-grid dependencies#576
Conversation
- Move formatters, DateUtils, and TableUtils out from iris-grid into @deephaven/jsapi-utils - Move Filter type definitions to @deephaven/filters - No more `iris-grid/dist` imports - @deephaven/chart no longer depends on @deephaven/iris-grid - Fixes 549
Codecov Report
@@ Coverage Diff @@
## main #576 +/- ##
==========================================
- Coverage 36.78% 36.50% -0.29%
==========================================
Files 390 390
Lines 28678 28613 -65
Branches 6777 6745 -32
==========================================
- Hits 10549 10444 -105
- Misses 17787 17827 +40
Partials 342 342
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| "react": "^17.0.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@deephaven/filters": "file:../filters", |
There was a problem hiding this comment.
I think the file path is fine for dev deps though. Since you would have the entire monorepo downloaded for development, but not for installing as a normal dep in a project
There was a problem hiding this comment.
See my above comment - it is fine for devDependencies and dependencies, does not appear to be fine for peerDependencies (which we should probably remove from most of our packages anyway.
- Removed unused prop-types dependency - Use named export over default export
iris-grid/distimports