Remove enzyme from all packages#577
Merged
Zhou-Ziheng merged 18 commits intodeephaven:mainfrom May 19, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #577 +/- ##
==========================================
- Coverage 36.83% 36.79% -0.04%
==========================================
Files 390 390
Lines 28661 28656 -5
Branches 6780 6779 -1
==========================================
- Hits 10558 10545 -13
- Misses 17757 17766 +9
+ Partials 346 345 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Zhou-Ziheng
changed the title
mofojed
requested changes
May 17, 2022
packages/dashboard-core-plugins/src/panels/IrisGridPanel.test.jsx
Outdated
Show resolved
Hide resolved
…m-dashboard-core-plugins
mofojed
previously approved these changes
May 18, 2022
|
|
||
| function expectLoading() { | ||
| expect(screen.getAllByRole('img', { hidden: true }).length).toBe(2); | ||
| function expectLoading(container) { |
Member
There was a problem hiding this comment.
I thought you were going to add a title to the LoadingSpinner? This is fine too, just means you need to pass in the container as well.
Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
May 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #570