Skip to content

Fix unintended scroll wheel behavior for single row and column tables#600

Merged
mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon:scroll-fix
Jun 2, 2022
Merged

Fix unintended scroll wheel behavior for single row and column tables#600
mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon:scroll-fix

Conversation

@mattrunyon
Copy link
Collaborator

Fixes #599

@mattrunyon mattrunyon added the bug Something isn't working label Jun 2, 2022
@mattrunyon mattrunyon requested a review from mofojed June 2, 2022 17:46
@mattrunyon mattrunyon self-assigned this Jun 2, 2022
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

Merging #600 (ca0556c) into main (c345a53) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   36.50%   36.50%           
=======================================
  Files         390      390           
  Lines       28613    28613           
  Branches     6745     6747    +2     
=======================================
  Hits        10444    10444           
  Misses      17827    17827           
  Partials      342      342           
Flag Coverage Δ
unit 36.50% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/grid/src/Grid.tsx 64.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c345a53...ca0556c. Read the comment docs.

@mattrunyon mattrunyon merged commit 0b31f01 into deephaven:main Jun 2, 2022
@mattrunyon mattrunyon deleted the scroll-fix branch June 2, 2022 19:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scrolling with mouse-wheel on single cell grid makes the grid jump

2 participants