Fix grid resizing automatically when outer parent size not specified#603
Merged
mofojed merged 1 commit intodeephaven:mainfrom Jun 3, 2022
Merged
Fix grid resizing automatically when outer parent size not specified#603mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
Canvas renders a new line after the element (apparently). Set it to display: block so it doesn't. See https://stackoverflow.com/questions/15807833/div-containing-canvas-have-got-a-strange-bottom-margin-of-5px Fixes deephaven#602
Codecov Report
@@ Coverage Diff @@
## main #603 +/- ##
=======================================
Coverage 36.50% 36.50%
=======================================
Files 390 390
Lines 28613 28615 +2
Branches 6747 6747
=======================================
+ Hits 10444 10446 +2
Misses 17827 17827
Partials 342 342
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dsmmcken
approved these changes
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canvas renders a new line after the element (apparently). Set it to display: block so it doesn't.
See https://stackoverflow.com/questions/15807833/div-containing-canvas-have-got-a-strange-bottom-margin-of-5px
Fixes #602