Skip to content

Fix arrow keys not selecting next console suggestion#629

Merged
mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon:console-down-arrow-fix
Jun 29, 2022
Merged

Fix arrow keys not selecting next console suggestion#629
mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon:console-down-arrow-fix

Conversation

@mattrunyon
Copy link
Collaborator

Fixes #617

@mattrunyon mattrunyon added the bug Something isn't working label Jun 28, 2022
@mattrunyon mattrunyon requested a review from mofojed June 28, 2022 20:08
@mattrunyon mattrunyon self-assigned this Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #629 (310850f) into main (ae071bb) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
- Coverage   35.86%   35.85%   -0.01%     
==========================================
  Files         396      396              
  Lines       29165    29169       +4     
  Branches     6948     6952       +4     
==========================================
  Hits        10459    10459              
- Misses      18520    18524       +4     
  Partials      186      186              
Flag Coverage Δ
unit 35.85% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/console/src/ConsoleInput.jsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae071bb...310850f. Read the comment docs.

@mattrunyon mattrunyon merged commit e8515f5 into deephaven:main Jun 29, 2022
@mattrunyon mattrunyon deleted the console-down-arrow-fix branch June 29, 2022 18:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Down arrow in console suggestions moves cursor

2 participants