Skip to content

Fix issue with not showing all data and not showing scroll bar#635

Merged
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:542-hidden-data
Jul 6, 2022
Merged

Fix issue with not showing all data and not showing scroll bar#635
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:542-hidden-data

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Jun 29, 2022

- On resize, double check that the left/top values are still valid
- Fixes deephaven#542
@mofojed mofojed added the bug Something isn't working label Jun 29, 2022
@mofojed mofojed added this to the June 2022 milestone Jun 29, 2022
@mofojed mofojed requested a review from vbabich June 29, 2022 20:59
@mofojed mofojed self-assigned this Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #635 (7eed5fa) into main (ae071bb) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
- Coverage   35.86%   35.75%   -0.11%     
==========================================
  Files         396      396              
  Lines       29165    29190      +25     
  Branches     6948     6960      +12     
==========================================
- Hits        10459    10436      -23     
- Misses      18520    18568      +48     
  Partials      186      186              
Flag Coverage Δ
unit 35.75% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/grid/src/Grid.tsx 64.02% <0.00%> (-0.58%) ⬇️
packages/iris-grid/src/IrisGridRenderer.ts 22.24% <0.00%> (-2.12%) ⬇️
...mousehandlers/IrisGridColumnTooltipMouseHandler.ts 7.31% <0.00%> (-2.06%) ⬇️
packages/console/src/common/ObjectIcon.tsx 8.33% <0.00%> (-1.67%) ⬇️
...ckages/iris-grid/src/IrisGridTableModelTemplate.ts 40.61% <0.00%> (-1.36%) ⬇️
...ouse-handlers/GridVerticalScrollBarMouseHandler.ts 33.78% <0.00%> (-0.89%) ⬇️
...se-handlers/GridHorizontalScrollBarMouseHandler.ts 33.78% <0.00%> (-0.89%) ⬇️
packages/iris-grid/src/IrisGridProxyModel.ts 63.36% <0.00%> (-0.67%) ⬇️
packages/iris-grid/src/IrisGrid.tsx 27.46% <0.00%> (-0.07%) ⬇️
packages/console/src/ConsoleInput.jsx 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae071bb...7eed5fa. Read the comment docs.

@mofojed mofojed modified the milestones: June 2022, July 2022 Jul 5, 2022
@mofojed mofojed merged commit b698842 into deephaven:main Jul 6, 2022
@mofojed mofojed deleted the 542-hidden-data branch July 6, 2022 19:20
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grid horizontal scroll bar can disappear with hidden data on panel resize

2 participants