Fix filter set capture failing on timestamp column advanced filters, DH-12754#649
Merged
vbabich merged 1 commit intodeephaven:mainfrom Jul 12, 2022
Merged
Conversation
…already dehydrated
Codecov Report
@@ Coverage Diff @@
## main #649 +/- ##
=======================================
Coverage 35.72% 35.72%
=======================================
Files 396 396
Lines 29228 29226 -2
Branches 6978 6978
=======================================
Hits 10442 10442
+ Misses 18599 18597 -2
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mofojed
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were dehydrating the filters from the
irisGridStatethat were already dehydrated. This worked fine in most cases, but failed on timestamp column advanced filters.