Skip to content

Fix filter set capture failing on timestamp column advanced filters, DH-12754#649

Merged
vbabich merged 1 commit intodeephaven:mainfrom
vbabich:fix-filter-set-capture
Jul 12, 2022
Merged

Fix filter set capture failing on timestamp column advanced filters, DH-12754#649
vbabich merged 1 commit intodeephaven:mainfrom
vbabich:fix-filter-set-capture

Conversation

@vbabich
Copy link
Collaborator

@vbabich vbabich commented Jul 12, 2022

We were dehydrating the filters from the irisGridState that were already dehydrated. This worked fine in most cases, but failed on timestamp column advanced filters.

@vbabich vbabich added the bug Something isn't working label Jul 12, 2022
@vbabich vbabich requested a review from mofojed July 12, 2022 16:52
@vbabich vbabich self-assigned this Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #649 (b8e6706) into main (1a8bb7c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   35.72%   35.72%           
=======================================
  Files         396      396           
  Lines       29228    29226    -2     
  Branches     6978     6978           
=======================================
  Hits        10442    10442           
+ Misses      18599    18597    -2     
  Partials      187      187           
Flag Coverage Δ
unit 35.72% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-core-plugins/src/panels/FilterSetManagerPanel.jsx 64.34% <ø> (+0.98%) ⬆️
...s/code-studio/src/storage/LocalWorkspaceStorage.ts 13.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a8bb7c...b8e6706. Read the comment docs.

@vbabich vbabich merged commit 84d1a59 into deephaven:main Jul 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants