Revive autocomplete deephaven-core#682#67
Conversation
|
Do NOT merge until deephaven/deephaven-core#682 merges, else we'll have very broken clients. |
JamesXNelson
force-pushed
the
jxn/autocomplete
branch
from
1d61b7d to
d6fa2c1
Compare
JamesXNelson
force-pushed
the
jxn/autocomplete
branch
from
d6fa2c1 to
fc8d679
Compare
|
Fixed imports. not sure if you want me to reorder the import that I do have to make it cleaner or not? |
| import { PromiseUtils } from '@deephaven/utils'; | ||
| import { getCommandHistoryStorage } from '@deephaven/redux'; | ||
| import MonacoUtils from './monaco/MonacoUtils'; | ||
| import MonacoCompletionProvider from './MonacoCompletionProvider'; |
There was a problem hiding this comment.
It would make sense to move this into console/src/monaco as well, then make an index file that exports all of them, so you can just do import { MonacoCompletionProvider, MonacoTheme, MonacoUtils } from './monaco', would be nice little cleanup.
There was a problem hiding this comment.
Does that work for MonacoTheme, even though it is imported from ./monaco/MonacoTheme.module.scss ?
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
You'll need to update ScriptEditor as well, there's a couple of commented out lines there calling MonacoUtils.openDocument and MonacoUtils.closeDocument (it's already calling getCompletionItems)
JamesXNelson
force-pushed
the
jxn/autocomplete
branch
from
ba05f1a to
60c07ef
Compare
2 participants
No description provided.