Implement react redux registry#71
Merged
spasovski merged 2 commits intodeephaven:mainfrom Jun 15, 2021
Merged
Conversation
Allows modular code to register reducers Blog post: http://nicolasgallagher.com/redux-modules-and-code-splitting/
spasovski
reviewed
Jun 15, 2021
|
|
||
| register(name: string, reducer: Reducer): void { | ||
| this.reducers = { ...this.reducers, [name]: reducer }; | ||
| this.listener?.(this.reducers); |
Contributor
There was a problem hiding this comment.
Haven't seen this in a function call before - freaky!
spasovski
approved these changes
Jun 15, 2021
Contributor
spasovski
left a comment
spasovski
left a comment
There was a problem hiding this comment.
Looks good though I am certainly not familiar with Nicolas' approach of a reducer registry. In ether case I am glad this works.
This was referenced Jun 16, 2021
mofojed
added a commit
that referenced
this pull request
Jun 24, 2021
Related to #71 . When the registry was added, it was first creating the store with no reducers, which caused this error to be printed out. Now, add reducers to the registry before creating the store to avoid the error. Note reducers can still be added to the registry after that fact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows modular code to register reducers
Blog post: http://nicolasgallagher.com/redux-modules-and-code-splitting/