Fix broken ctrl+e to clear filters shortcut (#664)#905
Merged
vbabich merged 1 commit intodeephaven:v0.13from Nov 30, 2022
Merged
Fix broken ctrl+e to clear filters shortcut (#664)#905vbabich merged 1 commit intodeephaven:v0.13from
vbabich merged 1 commit intodeephaven:v0.13from
Conversation
Collaborator
vbabich
commented
Nov 29, 2022
vbabich
commented
- Resolves "Clear All Tables Filters" Keyboard Shortcut not working #663 by copying enterprise fix DH-12258. Removes dead code.
- Fix shortcut broken by Separate dashboard into own package #203 Separating dashboard into own package
- Cleanup hjkl shortcuts to not conflict with ctrl+L for linker
- add shift key support
* Resolves deephaven#663 by copying enterprise fix DH-12258. Removes dead code. * Fix shortcut broken by deephaven#203 Seperating dashboard into own package * Cleanup hjkl shortcuts to not conflict with ctrl+L for linker * add shift key support
Member
|
Something's not right here - this used to work in Bard. Why are the global context actions not triggering before the grid key handler anymore? |
Contributor
|
#664 has context |
mofojed
approved these changes
Nov 30, 2022
Member
|
I've filed another ticket #913 , as I think Linker should have first crack at keyboard events rather than the underlying panels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.