[Deepin-Kernel-SIG] [linux 6.18.y] [Deepin] scsi: leapraid: correct LEAPRAID_REPLY_SIZE macro#1472
Conversation
deepin inclusion category: other fix the typo. Fixes: 08c6c3c ("scsi: leapraid: supports LeapRaid controller") Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideCorrects a misspelled LEAPRAID reply buffer size macro and updates all its usages to the proper LEAPRAID_REPLY_SIZE name in the LeapRaid SCSI driver, ensuring consistent calculations for reply buffer sizing, DMA allocation, and address handling. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Avenger-285714 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR fixes a typo in the LeapRAID SCSI driver by correcting the reply buffer size macro name and updating all of its uses accordingly. This removes an inconsistent/incorrect macro identifier while preserving the existing behavior and buffer sizing.
Changes:
- Rename
LEAPRAID_REPLY_SIEZtoLEAPRAID_REPLY_SIZEin the LeapRAID header to correct the macro name. - Update the reply buffer struct definition to use
LEAPRAID_REPLY_SIZE. - Update all reply-buffer-related calculations, DMA allocations/frees, address initialization, and userspace copy operations to use the corrected macro name.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| drivers/scsi/leapraid/leapraid_func.h | Fixes the reply size macro name and updates the leapraid_default_reply padding array to use the corrected identifier. |
| drivers/scsi/leapraid/leapraid_func.c | Replaces all uses of the old reply size macro in DMA size calculations, address range checks, and reply address initialization with LEAPRAID_REPLY_SIZE. |
| drivers/scsi/leapraid/leapraid_app.c | Updates memset and min_t calls that operate on the reply buffer to use the corrected LEAPRAID_REPLY_SIZE macro. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
#1470
deepin inclusion
category: other
fix the typo.
Fixes: 08c6c3c ("scsi: leapraid: supports LeapRaid controller")
Summary by Sourcery
Bug Fixes: