[Deepin-Kernel-SIG] [linux 6.18-y] [revyos] riscv: config: deepin: update config from revyos v6.18#1588
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the deepin RISC-V desktop defconfig to align with the upstream RevyOS/debian_defconfig configuration for Linux 6.18, refreshing kernel feature, driver, and subsystem options accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
d50c4a5 to
056ac47
Compare
There was a problem hiding this comment.
Pull request overview
Updates the Deepin RISC-V 64 desktop kernel defconfig to better align with the RevyOS/Debian configuration for Linux 6.18, expanding enabled subsystems, drivers, and security/features.
Changes:
- Adjust scheduler/preemption and core kernel feature selections (e.g., PREEMPT_LAZY, RCU_LAZY, Rust).
- Expand hardware/platform enablement (SoC/PCIe/USB/Bluetooth/WiFi, storage, I2C/SPI/pinctrl/GPIO).
- Broaden security/integrity and filesystem/network feature coverage (e.g., IPE in LSM list, more crypto/filesystems, NVMe-oF options).
Comments suppressed due to low confidence (1)
arch/riscv/configs/deepin_riscv64_desktop_defconfig:1506
- Several regulator drivers are enabled (e.g., CONFIG_REGULATOR_FIXED_VOLTAGE/AXP20X/DA9063/TPS65086), but the regulator framework menuconfig (CONFIG_REGULATOR) is not enabled in this defconfig. Because these options are all under
if REGULATOR(drivers/regulator/Kconfig), they will be dropped unless something else selects REGULATOR. Consider explicitly setting CONFIG_REGULATOR=y to ensure these modules are actually built.
CONFIG_MFD_TPS65086=m
CONFIG_REGULATOR_FIXED_VOLTAGE=m
CONFIG_REGULATOR_AXP20X=m
CONFIG_REGULATOR_DA9063=m
CONFIG_REGULATOR_TPS65086=m
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # CONFIG_SYSFS_SYSCALL is not set | ||
| CONFIG_KALLSYMS_ALL=y | ||
| CONFIG_PROFILING=y | ||
| CONFIG_RUST=y |
There was a problem hiding this comment.
CONFIG_RUST is enabled in this defconfig, which makes a Rust toolchain (rustc + bindgen at/above scripts/min-tool-version.sh) a hard build dependency. If the Deepin kernel build/CI environment does not guarantee Rust availability for riscv64, consider disabling CONFIG_RUST here or updating the build docs/CI to install the required toolchain.
| CONFIG_RUST=y | |
| # CONFIG_RUST is not set |
| CONFIG_MODULE_FORCE_UNLOAD=y | ||
| CONFIG_MODVERSIONS=y | ||
| CONFIG_GENDWARFKSYMS=y | ||
| CONFIG_MODULE_SIG_SHA256=y |
There was a problem hiding this comment.
CONFIG_MODULE_SIG_SHA256 is set, but CONFIG_MODULE_SIG is not enabled anywhere in this defconfig. As-is, the hash selection (and CONFIG_MODULE_SIG_KEY later) will be ignored by Kconfig; either enable module signing (CONFIG_MODULE_SIG=y, plus any policy options you need) or drop the module signing settings from the defconfig to avoid a misleading no-op.
| CONFIG_MODULE_SIG_SHA256=y | |
| # CONFIG_MODULE_SIG_SHA256 is not set |
| CONFIG_PACKET_DIAG=m | ||
| CONFIG_UNIX_DIAG=m | ||
| CONFIG_TLS=m | ||
| CONFIG_TLS_DEVICE=y |
There was a problem hiding this comment.
CONFIG_TLS_DEVICE depends on CONFIG_TLS (net/tls/Kconfig). Since CONFIG_TLS is not set anywhere in this defconfig, TLS_DEVICE will be forced off during olddefconfig. Enable CONFIG_TLS (m/y) if TLS offload is intended, or remove CONFIG_TLS_DEVICE to keep the defconfig consistent.
| CONFIG_TLS_DEVICE=y |
| CONFIG_NVME_RDMA=m | ||
| CONFIG_NVME_FC=m | ||
| CONFIG_NVME_TCP=m | ||
| CONFIG_NVME_TCP_TLS=y |
There was a problem hiding this comment.
NVME TCP TLS is enabled (CONFIG_NVME_TCP_TLS=y) but CONFIG_NVME_TCP is set to =m. Since NVME_TCP_TLS is a bool that depends on NVME_TCP (drivers/nvme/host/Kconfig), Kconfig will drop NVME_TCP_TLS unless NVME_TCP is built-in (=y). Align these settings (either make NVME_TCP=y if you want TLS, or disable NVME_TCP_TLS).
| CONFIG_NVME_TCP_TLS=y | |
| # CONFIG_NVME_TCP_TLS is not set |
| CONFIG_NVME_TARGET_FC=m | ||
| CONFIG_NVME_TARGET_FCLOOP=m | ||
| CONFIG_NVME_TARGET_TCP=m | ||
| CONFIG_NVME_TARGET_TCP_TLS=y |
There was a problem hiding this comment.
NVME target TCP TLS is enabled (CONFIG_NVME_TARGET_TCP_TLS=y) but CONFIG_NVME_TARGET_TCP is set to =m. Since NVME_TARGET_TCP_TLS is a bool that depends on NVME_TARGET_TCP (drivers/nvme/target/Kconfig), it will be forced off unless NVME_TARGET_TCP is built-in (=y). Align these options (make NVME_TARGET_TCP=y if TLS is desired, or disable NVME_TARGET_TCP_TLS).
| CONFIG_NVME_TARGET_TCP_TLS=y | |
| # CONFIG_NVME_TARGET_TCP_TLS is not set |
| CONFIG_DRM_AMDGPU_USERPTR=y | ||
| CONFIG_DRM_AMD_DC_SI=y | ||
| CONFIG_HSA_AMD=y | ||
| # CONFIG_HSA_AMD_SVM is not set |
There was a problem hiding this comment.
这个有什么特殊的原因吗
我怀疑riscv上也有问题(&& !LOONGARCH && !ARM64)
config HSA_AMD_SVM
bool "Enable HMM-based shared virtual memory manager"
depends on HSA_AMD && DEVICE_PRIVATE && !LOONGARCH && !ARM64
| CONFIG_PAGE_POISONING=y | ||
| CONFIG_SCHED_STACK_END_CHECK=y | ||
| CONFIG_DEBUG_MEMORY_INIT=y | ||
| CONFIG_MEMORY_NOTIFIER_ERROR_INJECT=m |
There was a problem hiding this comment.
这个有必要嘛
这个只是模块 开了也不影响,x86也打开了
| CONFIG_TRACER_SNAPSHOT=y | ||
| CONFIG_BLK_DEV_IO_TRACE=y | ||
| CONFIG_IO_STRICT_DEVMEM=y | ||
| CONFIG_KUNIT=m |
| CONFIG_CRYPTO_FIPS=y | ||
| CONFIG_CRYPTO_USER=m | ||
| # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set | ||
| CONFIG_CRYPTO_SELFTESTS=y |
| CONFIG_PATA_TOSHIBA=m | ||
| CONFIG_ATA_GENERIC=m | ||
| CONFIG_MD=y | ||
| CONFIG_MD_LINEAR=m |
| CONFIG_BPF_JIT=y | ||
| CONFIG_BPF_LSM=y | ||
| CONFIG_PREEMPT_VOLUNTARY=y | ||
| CONFIG_PREEMPT_LAZY=y |
There was a problem hiding this comment.
建议 @opsiff 大神跑分测一下。如果该选项性能比 CONFIG_PREEMPT_VOLUNTARY 更优,可以考虑整一个全架构的替换。甚至考虑 backport 至 linux-6.6.y。没记错的话 linux-6.12.y 及以前没有该选项。
There was a problem hiding this comment.
建议 @opsiff 大神跑分测一下。如果该选项性能比 CONFIG_PREEMPT_VOLUNTARY 更优,可以考虑整一个全架构的替换。甚至考虑 backport 至 linux-6.6.y。没记错的话 linux-6.12.y 及以前没有该选项。
暂时不改 后面观察一下
Link: https://github.com/revyos/linux/blob/68e2cc426827976f3667c9d3e3e58ee1943e4a18/arch/riscv/configs/debian_defconfig Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
056ac47 to
045260a
Compare
Link: https://github.com/revyos/linux/blob/68e2cc426827976f3667c9d3e3e58ee1943e4a18/arch/riscv/configs/debian_defconfig
Summary by Sourcery
Update the deepin RISC-V 64 desktop kernel defconfig to align with the RevyOS/debian configuration for Linux 6.18.