(kernel-rolling) arch: Add LoongArch Old BPI (old-world firmware interface) support #179

MingcongBai · 2024-05-22T03:19:55Z

Picked and rebased from #130.

From original pull request:

This is a general PR, mainly adding compatibility support for ABI1.0 and ABI2.0, and some fixes. In addition, we also update deepin_loongarch_desktop_defconfig to boot Fedora.

Some links:
Fedora ISO: https://github.com/fedora-remix-loongarch/releases-info
Diff of ABI1.0 and ABI2.0: https://github.com/loongson/LoongArch-Documentation/pull/74
Firmware: https://github.com/loongson/Firmware/tree/main

    Rebase to the latest state of the branch compared to the previous pull request.

Yanteng Si (6):
LoongArch: add kernel setvirtmap for runtime
LoongArch: Old BPI compatibility
LoongArch: Fix virtual machine startup error
LoongArch: Fixed EIOINTC structure members
LoongArch: use arch specific phys_to_dma
LoongArch: Update deepin_loongarch_desktop_defconfig

Builds tested

amd64
arm64
loong64

deepin-ci-robot · 2024-05-22T03:20:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zccrs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

https:/raw.githubusercontent.com/deepin-community/template-repository/master/debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot · 2024-05-22T03:20:12Z

Hi @MingcongBai. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: liuyun <liuyun@loongson.cn> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

Signed-off-by: liuyun <liuyun@loongson.cn> Signed-off-by: maobibo <maobibo@loongson.cn> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

Resolve the problem that the multi-node cpus fail to boot. Signed-off-by: yangqiming <yangqiming@loongson.cn> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

To be compatible with OLD firmware which has no _DMA method, we should use arch specific phys_to_dma. Signed-off-by: Hongchen Zhang <zhanghongchen@loongson.cn> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

The current config can't boot fedora, let's update it. Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

deepin-ci-robot · 2024-05-29T01:25:59Z

deepin pr auto review

loongarch: Fix interrupt routing on EIOCP

Prior to this commit, the interrupt routing on EIOCP was done
incorrectly. This patch fixes the issue by correctly parsing the
_CRS (Configuration Resources) table and setting up the interrupt
routing according to the ACPI specification.

loongarch: Fix interrupt routing on EIOCP

Prior to this commit, the interrupt routing on EIOCP was done
incorrectly. This patch fixes the issue by correctly parsing the
_CRS (Configuration Resources) table and setting up the interrupt
routing according to the ACPI specification.

MingcongBai · 2024-05-29T03:22:05Z

Fails to build on loong64:

arch/loongarch/kernel/legacy_boot.c:94:6: error: no previous prototype for 'register_default_pic' [-Werror=missing-prototypes]
   94 | void register_default_pic(int id, u32 address, u32 irq_base)
      |      ^~~~~~~~~~~~~~~~~~~~
arch/loongarch/kernel/legacy_boot.c:259:13: error: no previous prototype for 'fw_init_cmdline' [-Werror=missing-prototypes]
  259 | __init void fw_init_cmdline(unsigned long argc, unsigned long cmdp)
      |             ^~~~~~~~~~~~~~~
arch/loongarch/kernel/legacy_boot.c:358:14: error: no previous prototype for 'bpi_init' [-Werror=missing-prototypes]
  358 | unsigned int bpi_init(void)
      |              ^~~~~~~~
cc1: all warnings being treated as errors

@Avenger-285714 @opsiff

[ Upstream commit 6402078bd9d1ed46e79465e1faaa42e3458f8a33 ] When smc91x.c is built with PREEMPT_RT, the following splat occurs in FVP_RevC: [ 13.055000] smc91x LNRO0003:00 eth0: link up, 10Mbps, half-duplex, lpa 0x0000 [ 13.062137] BUG: workqueue leaked atomic, lock or RCU: kworker/2:1[106] [ 13.062137] preempt=0x00000000 lock=0->0 RCU=0->1 workfn=mld_ifc_work [ 13.062266] C ** replaying previous printk message ** [ 13.062266] CPU: 2 UID: 0 PID: 106 Comm: kworker/2:1 Not tainted 6.18.0-dirty deepin-community#179 PREEMPT_{RT,(full)} [ 13.062353] Hardware name: , BIOS [ 13.062382] Workqueue: mld mld_ifc_work [ 13.062469] Call trace: [ 13.062494] show_stack+0x24/0x40 (C) [ 13.062602] __dump_stack+0x28/0x48 [ 13.062710] dump_stack_lvl+0x7c/0xb0 [ 13.062818] dump_stack+0x18/0x34 [ 13.062926] process_scheduled_works+0x294/0x450 [ 13.063043] worker_thread+0x260/0x3d8 [ 13.063124] kthread+0x1c4/0x228 [ 13.063235] ret_from_fork+0x10/0x20 This happens because smc_special_trylock() disables IRQs even on PREEMPT_RT, but smc_special_unlock() does not restore IRQs on PREEMPT_RT. The reason is that smc_special_unlock() calls spin_unlock_irqrestore(), and rcu_read_unlock_bh() in __dev_queue_xmit() cannot invoke rcu_read_unlock() through __local_bh_enable_ip() when current->softirq_disable_cnt becomes zero. To address this issue, replace smc_special_trylock() with spin_trylock_irqsave(). Fixes: 342a932 ("locking/spinlock: Provide RT variant header: <linux/spinlock_rt.h>") Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20251217085115.1730036-1-yeoreum.yun@arm.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org> (cherry picked from commit 36561b86cb2501647662cfaf91286dd6973804a6) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

[ Upstream commit 6402078bd9d1ed46e79465e1faaa42e3458f8a33 ] When smc91x.c is built with PREEMPT_RT, the following splat occurs in FVP_RevC: [ 13.055000] smc91x LNRO0003:00 eth0: link up, 10Mbps, half-duplex, lpa 0x0000 [ 13.062137] BUG: workqueue leaked atomic, lock or RCU: kworker/2:1[106] [ 13.062137] preempt=0x00000000 lock=0->0 RCU=0->1 workfn=mld_ifc_work [ 13.062266] C ** replaying previous printk message ** [ 13.062266] CPU: 2 UID: 0 PID: 106 Comm: kworker/2:1 Not tainted 6.18.0-dirty deepin-community#179 PREEMPT_{RT,(full)} [ 13.062353] Hardware name: , BIOS [ 13.062382] Workqueue: mld mld_ifc_work [ 13.062469] Call trace: [ 13.062494] show_stack+0x24/0x40 (C) [ 13.062602] __dump_stack+0x28/0x48 [ 13.062710] dump_stack_lvl+0x7c/0xb0 [ 13.062818] dump_stack+0x18/0x34 [ 13.062926] process_scheduled_works+0x294/0x450 [ 13.063043] worker_thread+0x260/0x3d8 [ 13.063124] kthread+0x1c4/0x228 [ 13.063235] ret_from_fork+0x10/0x20 This happens because smc_special_trylock() disables IRQs even on PREEMPT_RT, but smc_special_unlock() does not restore IRQs on PREEMPT_RT. The reason is that smc_special_unlock() calls spin_unlock_irqrestore(), and rcu_read_unlock_bh() in __dev_queue_xmit() cannot invoke rcu_read_unlock() through __local_bh_enable_ip() when current->softirq_disable_cnt becomes zero. To address this issue, replace smc_special_trylock() with spin_trylock_irqsave(). Fixes: 342a932 ("locking/spinlock: Provide RT variant header: <linux/spinlock_rt.h>") Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20251217085115.1730036-1-yeoreum.yun@arm.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org> (cherry picked from commit ef277ae121b3249c99994652210a326b52d527b0) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

[ Upstream commit 6402078bd9d1ed46e79465e1faaa42e3458f8a33 ] When smc91x.c is built with PREEMPT_RT, the following splat occurs in FVP_RevC: [ 13.055000] smc91x LNRO0003:00 eth0: link up, 10Mbps, half-duplex, lpa 0x0000 [ 13.062137] BUG: workqueue leaked atomic, lock or RCU: kworker/2:1[106] [ 13.062137] preempt=0x00000000 lock=0->0 RCU=0->1 workfn=mld_ifc_work [ 13.062266] C ** replaying previous printk message ** [ 13.062266] CPU: 2 UID: 0 PID: 106 Comm: kworker/2:1 Not tainted 6.18.0-dirty #179 PREEMPT_{RT,(full)} [ 13.062353] Hardware name: , BIOS [ 13.062382] Workqueue: mld mld_ifc_work [ 13.062469] Call trace: [ 13.062494] show_stack+0x24/0x40 (C) [ 13.062602] __dump_stack+0x28/0x48 [ 13.062710] dump_stack_lvl+0x7c/0xb0 [ 13.062818] dump_stack+0x18/0x34 [ 13.062926] process_scheduled_works+0x294/0x450 [ 13.063043] worker_thread+0x260/0x3d8 [ 13.063124] kthread+0x1c4/0x228 [ 13.063235] ret_from_fork+0x10/0x20 This happens because smc_special_trylock() disables IRQs even on PREEMPT_RT, but smc_special_unlock() does not restore IRQs on PREEMPT_RT. The reason is that smc_special_unlock() calls spin_unlock_irqrestore(), and rcu_read_unlock_bh() in __dev_queue_xmit() cannot invoke rcu_read_unlock() through __local_bh_enable_ip() when current->softirq_disable_cnt becomes zero. To address this issue, replace smc_special_trylock() with spin_trylock_irqsave(). Fixes: 342a932 ("locking/spinlock: Provide RT variant header: <linux/spinlock_rt.h>") Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20251217085115.1730036-1-yeoreum.yun@arm.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org> (cherry picked from commit ef277ae121b3249c99994652210a326b52d527b0) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

[ Upstream commit 6402078bd9d1ed46e79465e1faaa42e3458f8a33 ] When smc91x.c is built with PREEMPT_RT, the following splat occurs in FVP_RevC: [ 13.055000] smc91x LNRO0003:00 eth0: link up, 10Mbps, half-duplex, lpa 0x0000 [ 13.062137] BUG: workqueue leaked atomic, lock or RCU: kworker/2:1[106] [ 13.062137] preempt=0x00000000 lock=0->0 RCU=0->1 workfn=mld_ifc_work [ 13.062266] C ** replaying previous printk message ** [ 13.062266] CPU: 2 UID: 0 PID: 106 Comm: kworker/2:1 Not tainted 6.18.0-dirty deepin-community#179 PREEMPT_{RT,(full)} [ 13.062353] Hardware name: , BIOS [ 13.062382] Workqueue: mld mld_ifc_work [ 13.062469] Call trace: [ 13.062494] show_stack+0x24/0x40 (C) [ 13.062602] __dump_stack+0x28/0x48 [ 13.062710] dump_stack_lvl+0x7c/0xb0 [ 13.062818] dump_stack+0x18/0x34 [ 13.062926] process_scheduled_works+0x294/0x450 [ 13.063043] worker_thread+0x260/0x3d8 [ 13.063124] kthread+0x1c4/0x228 [ 13.063235] ret_from_fork+0x10/0x20 This happens because smc_special_trylock() disables IRQs even on PREEMPT_RT, but smc_special_unlock() does not restore IRQs on PREEMPT_RT. The reason is that smc_special_unlock() calls spin_unlock_irqrestore(), and rcu_read_unlock_bh() in __dev_queue_xmit() cannot invoke rcu_read_unlock() through __local_bh_enable_ip() when current->softirq_disable_cnt becomes zero. To address this issue, replace smc_special_trylock() with spin_trylock_irqsave(). Fixes: 342a932 ("locking/spinlock: Provide RT variant header: <linux/spinlock_rt.h>") Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://patch.msgid.link/20251217085115.1730036-1-yeoreum.yun@arm.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org> (cherry picked from commit b6018d5c1a8f09d5efe4d6961d7ee45fdf3a7ce3) Signed-off-by: Wentao Guan <guanwentao@uniontech.com>

deepin-ci-robot requested review from BLumia and justforlxz May 22, 2024 03:20

deepin-ci-robot added the needs-ok-to-test label May 22, 2024

Yanteng Si added 6 commits May 29, 2024 08:36

LoongArch: add kernel setvirtmap for runtime

ce4a6ab

Signed-off-by: liuyun <liuyun@loongson.cn> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

LoongArch: Old BPI compatibility

a1eafc4

Signed-off-by: liuyun <liuyun@loongson.cn> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

LoongArch: Fix virtual machine startup error

2065f65

Signed-off-by: liuyun <liuyun@loongson.cn> Signed-off-by: maobibo <maobibo@loongson.cn> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

LoongArch: Fixed EIOINTC structure members

f0b1cd8

Resolve the problem that the multi-node cpus fail to boot. Signed-off-by: yangqiming <yangqiming@loongson.cn> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

LoongArch: use arch specific phys_to_dma

c6cc01f

To be compatible with OLD firmware which has no _DMA method, we should use arch specific phys_to_dma. Signed-off-by: Hongchen Zhang <zhanghongchen@loongson.cn> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

LoongArch: Update deepin_loongarch_desktop_defconfig

39b82fe

The current config can't boot fedora, let's update it. Signed-off-by: Yanteng Si <siyanteng@loongson.cn>

MingcongBai force-pushed the bai/kernel-rolling/loongarch-old-bpi branch from 670cb3e to 39b82fe Compare May 29, 2024 00:37

MingcongBai closed this Jun 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(kernel-rolling) arch: Add LoongArch Old BPI (old-world firmware interface) support #179

(kernel-rolling) arch: Add LoongArch Old BPI (old-world firmware interface) support #179

Uh oh!

MingcongBai commented May 22, 2024 •

edited

Loading

Uh oh!

deepin-ci-robot commented May 22, 2024

Uh oh!

deepin-ci-robot commented May 22, 2024

Uh oh!

deepin-ci-robot commented May 29, 2024

Uh oh!

MingcongBai commented May 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

(kernel-rolling) arch: Add LoongArch Old BPI (old-world firmware interface) support #179

(kernel-rolling) arch: Add LoongArch Old BPI (old-world firmware interface) support #179

Uh oh!

Conversation

MingcongBai commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Builds tested

Uh oh!

deepin-ci-robot commented May 22, 2024

Uh oh!

deepin-ci-robot commented May 22, 2024

Uh oh!

deepin-ci-robot commented May 29, 2024

deepin pr auto review

Uh oh!

MingcongBai commented May 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MingcongBai commented May 22, 2024 •

edited

Loading