can: phytium: Use phytium_can_of_ids only when CONFIG_OF enabled #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix follow errors:
drivers/net/can/phytium/phytium_can_platform.c: In function ‘phytium_can_plat_probe’:
drivers/net/can/phytium/phytium_can_platform.c:113:41: error: ‘phytium_can_of_ids’ undeclared (first use in this function); did you mean ‘phytium_can_acpi_ids’?
113 | of_id = of_match_device(phytium_can_of_ids, &pdev->dev);
| ^~~~~~~~~~~~~~~~~~
| phytium_can_acpi_ids
drivers/net/can/phytium/phytium_can_platform.c:113:41: note: each undeclared identifier is reported only once for each function it appears in
Signed-off-by: WangYuli <wangyuli@uniontech.com>
deepin pr auto review关键摘要:
是否建议立即修改:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
opsiff
pushed a commit
to opsiff/UOS-kernel
that referenced
this pull request
Jan 5, 2026
Fix follow errors:
drivers/net/can/phytium/phytium_can_platform.c: In function ‘phytium_can_plat_probe’:
drivers/net/can/phytium/phytium_can_platform.c:113:41: error: ‘phytium_can_of_ids’ undeclared (first use in this function); did you mean ‘phytium_can_acpi_ids’?
113 | of_id = of_match_device(phytium_can_of_ids, &pdev->dev);
| ^~~~~~~~~~~~~~~~~~
| phytium_can_acpi_ids
drivers/net/can/phytium/phytium_can_platform.c:113:41: note: each undeclared identifier is reported only once for each function it appears in
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Link: deepin-community#374
(cherry picked from commit 759f31a)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
opsiff
pushed a commit
to opsiff/UOS-kernel
that referenced
this pull request
Jan 5, 2026
Fix follow errors:
drivers/net/can/phytium/phytium_can_platform.c: In function ‘phytium_can_plat_probe’:
drivers/net/can/phytium/phytium_can_platform.c:113:41: error: ‘phytium_can_of_ids’ undeclared (first use in this function); did you mean ‘phytium_can_acpi_ids’?
113 | of_id = of_match_device(phytium_can_of_ids, &pdev->dev);
| ^~~~~~~~~~~~~~~~~~
| phytium_can_acpi_ids
drivers/net/can/phytium/phytium_can_platform.c:113:41: note: each undeclared identifier is reported only once for each function it appears in
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Link: deepin-community#374
(cherry picked from commit 759f31a)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
opsiff
pushed a commit
to opsiff/UOS-kernel
that referenced
this pull request
Jan 20, 2026
Fix follow errors:
drivers/net/can/phytium/phytium_can_platform.c: In function ‘phytium_can_plat_probe’:
drivers/net/can/phytium/phytium_can_platform.c:113:41: error: ‘phytium_can_of_ids’ undeclared (first use in this function); did you mean ‘phytium_can_acpi_ids’?
113 | of_id = of_match_device(phytium_can_of_ids, &pdev->dev);
| ^~~~~~~~~~~~~~~~~~
| phytium_can_acpi_ids
drivers/net/can/phytium/phytium_can_platform.c:113:41: note: each undeclared identifier is reported only once for each function it appears in
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Link: deepin-community#374
(cherry picked from commit 759f31a)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
lanlanxiyiji
pushed a commit
that referenced
this pull request
Jan 20, 2026
Fix follow errors:
drivers/net/can/phytium/phytium_can_platform.c: In function ‘phytium_can_plat_probe’:
drivers/net/can/phytium/phytium_can_platform.c:113:41: error: ‘phytium_can_of_ids’ undeclared (first use in this function); did you mean ‘phytium_can_acpi_ids’?
113 | of_id = of_match_device(phytium_can_of_ids, &pdev->dev);
| ^~~~~~~~~~~~~~~~~~
| phytium_can_acpi_ids
drivers/net/can/phytium/phytium_can_platform.c:113:41: note: each undeclared identifier is reported only once for each function it appears in
Signed-off-by: WangYuli <wangyuli@uniontech.com>
Link: #374
(cherry picked from commit 759f31a)
Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix follow errors:
drivers/net/can/phytium/phytium_can_platform.c: In function ‘phytium_can_plat_probe’: drivers/net/can/phytium/phytium_can_platform.c:113:41: error: ‘phytium_can_of_ids’ undeclared (first use in this function); did you mean ‘phytium_can_acpi_ids’?
113 | of_id = of_match_device(phytium_can_of_ids, &pdev->dev);
| ^~~~~~~~~~~~~~~~~~
| phytium_can_acpi_ids
drivers/net/can/phytium/phytium_can_platform.c:113:41: note: each undeclared identifier is reported only once for each function it appears in