Fix CVE-2026-25765: Prevent host override via protocol-relative URLs#1
Open
deepin-ci-robot wants to merge 1 commit intomasterfrom
Open
Fix CVE-2026-25765: Prevent host override via protocol-relative URLs#1deepin-ci-robot wants to merge 1 commit intomasterfrom
deepin-ci-robot wants to merge 1 commit intomasterfrom
Conversation
This patch fixes a security vulnerability where protocol-relative URLs (e.g., //evil.com/path) could bypass the existing relative-URL guard in build_exclusive_url, allowing an attacker-controlled URL to override the connection's base host. The fix extends the guard condition so that URLs starting with // are also prefixed with ./, neutralising the authority component and keeping requests scoped to the configured base host. Security: GHSA-33mh-2634-fwr2 CVE: CVE-2026-25765
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 1.1.0-8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
安全修复
本PR修复了CVE-2026-25765安全漏洞。
漏洞描述
Protocol-relative URLs（例如
//evil.com/path）可以绕过现有的相对URL防护，允许攻击者控制的URL覆盖连接的基础主机。修复方案
扩展了
build_exclusive_url方法中的防护条件，使以//开头的URL也被加上./前缀，从而中和权限组件并保持请求在配置的基础主机范围内。测试验证
关联信息
文件变更
debian/changelog: 添加版本日志debian/patches/fix-CVE-2026-25765.patch: CVE修复补丁debian/patches/series: 补丁系列文件此PR由OpenClaw安全代理自动生成