Skip to content

refactor: consolidate paused_groups migration into standard include_str! pattern#83

Merged
deepjoy merged 1 commit into
mainfrom
fix-migration-script
Mar 24, 2026
Merged

refactor: consolidate paused_groups migration into standard include_str! pattern#83
deepjoy merged 1 commit into
mainfrom
fix-migration-script

Conversation

@deepjoy
Copy link
Copy Markdown
Owner

@deepjoy deepjoy commented Mar 24, 2026

Summary

  • Rename migrations/010_paused_groups.sql to 005_paused_groups.sql to follow the sequential numbering of existing migrations (001–004)
  • Replace inline SQL in TaskStore::migrate() with include_str!(), matching the pattern used by all other migrations
  • Remove the now-unnecessary ALTER TABLE and backfill UPDATE statements since the DB is always created fresh with the pause_reasons column already present in 001_tasks.sql

…tr! pattern

Rename 010_paused_groups.sql to 005 and replace inline SQL with
include_str!, matching migrations 001–004. Drop the now-unnecessary
ALTER TABLE and backfill statements since the DB is re-created.
@deepjoy deepjoy enabled auto-merge (squash) March 24, 2026 06:21
@deepjoy deepjoy merged commit cd2a5ac into main Mar 24, 2026
2 checks passed
@github-actions github-actions Bot mentioned this pull request Mar 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Benchmark Comparison

Click to expand
group                                       main                                    pr
-----                                       ----                                    --
backoff_delay/constant                      1.06     50.5±1.97ns 377.5 MElem/sec    1.00     47.6±0.14ns 400.6 MElem/sec
backoff_delay/exponential                   1.01    190.4±2.53ns 100.2 MElem/sec    1.00    188.1±1.07ns 101.4 MElem/sec
backoff_delay/exponential_jitter            1.00    269.8±9.22ns 70.7 MElem/sec     1.01    271.6±9.15ns 70.2 MElem/sec
backoff_delay/linear                        1.00     76.4±0.37ns 249.7 MElem/sec    1.06     80.9±0.47ns 235.6 MElem/sec
batch_submit/1000                           1.05     35.8±3.45ms 27.3 KElem/sec     1.00     34.1±2.86ms 28.7 KElem/sec
byte_progress/byte_reporting_500            1.03    200.5±5.64ms  2.4 KElem/sec     1.00    194.4±3.83ms  2.5 KElem/sec
byte_progress/noop_500                      1.07    195.9±5.26ms  2.5 KElem/sec     1.00    183.8±4.85ms  2.7 KElem/sec
byte_progress_snapshot/100_tasks            1.04     86.6±3.75ms  1154 Elem/sec     1.00     83.5±2.20ms  1197 Elem/sec
concurrency_scaling/1                       1.09    421.5±7.36ms  1186 Elem/sec     1.00    385.2±9.03ms  1297 Elem/sec
concurrency_scaling/2                       1.02    291.7±8.28ms  1713 Elem/sec     1.00    287.2±5.84ms  1741 Elem/sec
concurrency_scaling/4                       1.03    241.8±7.30ms  2.0 KElem/sec     1.00    235.3±9.06ms  2.1 KElem/sec
concurrency_scaling/8                       1.07    195.8±5.14ms  2.5 KElem/sec     1.00    182.3±4.34ms  2.7 KElem/sec
count_by_tags/100                           1.02    133.5±5.00µs  7.3 KElem/sec     1.00    130.6±3.34µs  7.5 KElem/sec
count_by_tags/1000                          1.03    226.0±5.06µs  4.3 KElem/sec     1.00    219.3±4.28µs  4.5 KElem/sec
count_by_tags/5000                          1.03   629.0±17.99µs  1589 Elem/sec     1.00   611.8±11.03µs  1634 Elem/sec
dep_chain_dispatch/10                       1.10     12.3±0.13ms   811 Elem/sec     1.00     11.2±0.33ms   892 Elem/sec
dep_chain_dispatch/25                       1.12     30.7±0.45ms   813 Elem/sec     1.00     27.3±0.25ms   914 Elem/sec
dep_chain_dispatch/50                       1.13     61.5±1.00ms   812 Elem/sec     1.00     54.6±0.89ms   916 Elem/sec
dep_chain_submit/10                         1.01      3.1±0.15ms  3.1 KElem/sec     1.00      3.1±0.12ms  3.2 KElem/sec
dep_chain_submit/200                        1.08     86.6±4.82ms  2.3 KElem/sec     1.00     79.8±4.94ms  2.4 KElem/sec
dep_chain_submit/50                         1.03     17.8±1.04ms  2.8 KElem/sec     1.00     17.3±1.05ms  2.8 KElem/sec
dep_fan_in_dispatch/10                      1.08      6.6±0.08ms  1675 Elem/sec     1.00      6.1±0.07ms  1802 Elem/sec
dep_fan_in_dispatch/100                     1.07     45.1±1.12ms  2.2 KElem/sec     1.00     42.1±1.11ms  2.3 KElem/sec
dep_fan_in_dispatch/50                      1.09     23.8±0.55ms  2.1 KElem/sec     1.00     21.8±0.45ms  2.3 KElem/sec
dispatch_and_complete/1000                  1.07    393.1±9.93ms  2.5 KElem/sec     1.00    367.7±8.36ms  2.7 KElem/sec
dispatch_group_scaling/1                    1.04    447.4±8.53ms  1117 Elem/sec     1.00    431.8±7.63ms  1158 Elem/sec
dispatch_group_scaling/10                   1.04    449.3±9.72ms  1112 Elem/sec     1.00    433.9±6.65ms  1152 Elem/sec
dispatch_group_scaling/100                  1.10    478.9±7.03ms  1044 Elem/sec     1.00    434.5±9.38ms  1150 Elem/sec
dispatch_group_scaling/50                   1.04    450.0±9.47ms  1111 Elem/sec     1.00    434.3±7.44ms  1151 Elem/sec
dispatch_no_groups/500                      1.09    203.9±5.96ms  2.4 KElem/sec     1.00    187.7±4.33ms  2.6 KElem/sec
dispatch_one_group/500                      1.03    447.3±9.76ms  1117 Elem/sec     1.00    432.7±7.30ms  1155 Elem/sec
dispatch_permanent_failure/500              1.06    380.2±5.98ms  1314 Elem/sec     1.00    357.3±5.58ms  1399 Elem/sec
history_by_type/100                         1.04    227.1±7.28µs  4.3 KElem/sec     1.00    219.2±6.07µs  4.5 KElem/sec
history_by_type/1000                        1.04   851.2±44.66µs  1174 Elem/sec     1.00   816.4±59.72µs  1224 Elem/sec
history_by_type/5000                        1.05   827.3±49.59µs  1208 Elem/sec     1.00   789.5±30.66µs  1266 Elem/sec
history_query/100                           1.02   440.3±18.28µs  2.2 KElem/sec     1.00   430.6±14.04µs  2.3 KElem/sec
history_query/1000                          1.00   432.6±15.86µs  2.3 KElem/sec     1.01   435.9±15.88µs  2.2 KElem/sec
history_query/5000                          1.02   425.7±18.33µs  2.3 KElem/sec     1.00   419.4±17.81µs  2.3 KElem/sec
history_stats/100                           1.03    132.0±1.28µs  7.4 KElem/sec     1.00    128.1±1.19µs  7.6 KElem/sec
history_stats/1000                          1.02    197.9±2.50µs  4.9 KElem/sec     1.00    193.8±1.07µs  5.0 KElem/sec
history_stats/5000                          1.02    488.3±4.51µs  2047 Elem/sec     1.00    477.3±7.37µs  2.0 KElem/sec
mixed_priority_dispatch/500                 1.04    245.1±7.51ms  2039 Elem/sec     1.00   235.0±11.33ms  2.1 KElem/sec
peek_next/100                               1.07    133.6±5.45µs  7.3 KElem/sec     1.00   125.0±10.87µs  7.8 KElem/sec
peek_next/1000                              1.10    135.0±5.69µs  7.2 KElem/sec     1.00    122.5±3.21µs  8.0 KElem/sec
peek_next/5000                              1.10    135.7±6.21µs  7.2 KElem/sec     1.00    123.6±3.53µs  7.9 KElem/sec
query_ids_by_tags/100                       1.02    189.0±3.38µs  5.2 KElem/sec     1.00    184.5±3.62µs  5.3 KElem/sec
query_ids_by_tags/1000                      1.00    776.2±8.41µs  1288 Elem/sec     1.01   787.8±25.61µs  1269 Elem/sec
query_ids_by_tags/5000                      1.02      3.4±0.07ms   290 Elem/sec     1.00      3.4±0.05ms   295 Elem/sec
retryable_dead_letter/constant              1.07    116.4±0.85ms   858 Elem/sec     1.00    109.1±1.02ms   916 Elem/sec
retryable_dead_letter/exponential           1.08    117.8±1.27ms   848 Elem/sec     1.00    108.7±0.62ms   919 Elem/sec
retryable_dead_letter/exponential_jitter    1.07    116.4±1.60ms   858 Elem/sec     1.00    108.7±0.84ms   920 Elem/sec
retryable_dead_letter/linear                1.08    117.4±1.05ms   852 Elem/sec     1.00    109.0±1.29ms   917 Elem/sec
submit_dedup_hit/1000                       1.04    219.2±9.07ms  4.4 KElem/sec     1.00    210.3±8.05ms  4.6 KElem/sec
submit_tasks/1000                           1.03    189.5±7.87ms  5.2 KElem/sec     1.00    183.4±5.35ms  5.3 KElem/sec
submit_with_tags/0                          1.07     98.5±5.20ms  5.0 KElem/sec     1.00     92.1±3.60ms  5.3 KElem/sec
submit_with_tags/10                         1.11   270.1±13.24ms  1851 Elem/sec     1.00   242.9±10.95ms  2.0 KElem/sec
submit_with_tags/20                         1.08   428.5±23.18ms  1166 Elem/sec     1.00   397.9±17.83ms  1256 Elem/sec
submit_with_tags/5                          1.13    188.3±9.14ms  2.6 KElem/sec     1.00    166.9±7.50ms  2.9 KElem/sec
tag_values/100                              1.03    141.7±6.56µs  6.9 KElem/sec     1.00    138.2±4.35µs  7.1 KElem/sec
tag_values/1000                             1.02    203.0±7.22µs  4.8 KElem/sec     1.00    199.2±4.97µs  4.9 KElem/sec
tag_values/5000                             1.01    467.5±9.90µs  2.1 KElem/sec     1.00    465.1±5.95µs  2.1 KElem/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant