Merged
Conversation
BurningEnlightenment
force-pushed
the
dev/ci-cleanup
branch
2 times, most recently
from
cd8685d to
ddf8bec
Compare
BurningEnlightenment
force-pushed
the
dev/ci-cleanup
branch
from
ddf8bec to
b22f25c
Compare
- `cppcoreguidelines-avoid-magic-numbers` aliases `readability-magic-numbers`.
Disable `cppcoreguidelines-macro-usage` for macros defined by the configure step.
The endian load code is in a `std::is_constant_evaluated()` branch, i.e. any undefined behaviour is guaranteed to be catched by the compiler.
- Avoid a trivial sign conversion. - Remove a few casts obsoleted by API changes. - Suppress useless cast warnings for `std::size_t`. - Rename a few params to avoid name shadowing.
BurningEnlightenment
force-pushed
the
dev/ci-cleanup
branch
from
71355ff to
764cfe0
Compare
The endian load_partial code is trivial to verify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix clang format and tidy issues in order to greenlight the CI.
Enable
WARNINGS_AS_ERRORSfor the CI.