Skip to content

Improve color_by_time#35

Merged
deeplycloudy merged 2 commits intodeeplycloudy:masterfrom
wx4stg:colorbytime
Jan 17, 2024
Merged

Improve color_by_time#35
deeplycloudy merged 2 commits intodeeplycloudy:masterfrom
wx4stg:colorbytime

Conversation

@wx4stg
Copy link
Copy Markdown
Contributor

@wx4stg wx4stg commented Jan 8, 2024

This allows for coloring numpy datetime64[ns] (used by event_time and flash_time_start) and even regular floats. tlim is now an optional kwarg, if it is not provided, it is assumed that the min and max of the time_array are the upper and lower bounds for tlim

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@f0bb273). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #35   +/-   ##
=========================================
  Coverage          ?   76.61%           
=========================================
  Files             ?       12           
  Lines             ?     1732           
  Branches          ?        0           
=========================================
  Hits              ?     1327           
  Misses            ?      405           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deeplycloudy
Copy link
Copy Markdown
Owner

This moves us away from the python datetime API, and toward numpy's datetime64, which I like as a time format to which we promote all datasets. Tests, etc. LGTM. Thanks for not breaking earlier compatibility.

@deeplycloudy deeplycloudy merged commit e9fc3ba into deeplycloudy:master Jan 17, 2024
@wx4stg wx4stg deleted the colorbytime branch February 20, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants