Skip to content

fix issue with incorrect station metadata info while reading lma file#49

Merged
deeplycloudy merged 1 commit intodeeplycloudy:masterfrom
gewitterblitz:lmafile_update
Aug 27, 2024
Merged

fix issue with incorrect station metadata info while reading lma file#49
deeplycloudy merged 1 commit intodeeplycloudy:masterfrom
gewitterblitz:lmafile_update

Conversation

@gewitterblitz
Copy link
Copy Markdown
Contributor

This should resolve issue #48.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.10%. Comparing base (f945c5e) to head (4e22a94).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   78.10%   78.10%           
=======================================
  Files          13       13           
  Lines        1955     1955           
=======================================
  Hits         1527     1527           
  Misses        428      428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wx4stg
Copy link
Copy Markdown
Contributor

wx4stg commented Aug 27, 2024

tested and confirmed that this resolves the referenced issue.

In summary, If multiple stations have duplicate ID letters, as long as <=1 is marked as "active", the file will read in to XLMA (tested using IDL 7 on windows arm64) but will not read into xlma-python, but this PR fixes that issue (this is also useful to know for my own personal future reference... thanks!)

closes #48

@deeplycloudy
Copy link
Copy Markdown
Owner

Thanks for finding and proposing a fix @gewitterblitz, and for the review @wx4stg. Merging!

@deeplycloudy deeplycloudy merged commit 300805c into deeplycloudy:master Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants