fix issue with incorrect station metadata info while reading lma file#49
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #49 +/- ##
=======================================
Coverage 78.10% 78.10%
=======================================
Files 13 13
Lines 1955 1955
=======================================
Hits 1527 1527
Misses 428 428 ☔ View full report in Codecov by Sentry. |
|
tested and confirmed that this resolves the referenced issue. In summary, If multiple stations have duplicate ID letters, as long as <=1 is marked as "active", the file will read in to XLMA (tested using IDL 7 on windows arm64) but will not read into xlma-python, but this PR fixes that issue (this is also useful to know for my own personal future reference... thanks!) closes #48 |
|
Thanks for finding and proposing a fix @gewitterblitz, and for the review @wx4stg. Merging! |
This should resolve issue #48.