Skip to content

fix #1147#1148

Merged
2 commits merged intooapi-codegen:masterfrom
const-tmp:master
Jul 28, 2023
Merged

fix #1147#1148
2 commits merged intooapi-codegen:masterfrom
const-tmp:master

Conversation

@const-tmp
Copy link
Copy Markdown
Contributor

Edit template for strict server. Implement json.Marshaler for $ref responses with fixed status code.

@const-tmp
Copy link
Copy Markdown
Contributor Author

#1147

@ghost ghost merged commit e393d91 into oapi-codegen:master Jul 28, 2023
ghost pushed a commit that referenced this pull request Jul 28, 2023
This reverts commit e393d91.

The generated files broke due to this change, so I'm rolling it
back.

Repro case is easy:

  go generate ./...
  go test ./...
@ghost
Copy link
Copy Markdown

ghost commented Jul 28, 2023

I merged this, but I had to roll it back, because the generated code broke and didn't compile.

When changing the code generator, rung go generate ./... at the top of the repo to regenerate everything. It exposes generation errors.

debuggerpk pushed a commit to breuHQ/oapi-codegen that referenced this pull request Sep 18, 2023
* fix oapi-codegen#1147

* implement json.Marshaler only for JSON content type

---------

Co-authored-by: anon <anon@local>
debuggerpk pushed a commit to breuHQ/oapi-codegen that referenced this pull request Sep 18, 2023
This reverts commit e393d91.

The generated files broke due to this change, so I'm rolling it
back.

Repro case is easy:

  go generate ./...
  go test ./...
danicc097 pushed a commit to danicc097/oapi-codegen that referenced this pull request Aug 31, 2024
* fix oapi-codegen#1147

* implement json.Marshaler only for JSON content type

---------

Co-authored-by: anon <anon@local>
danicc097 pushed a commit to danicc097/oapi-codegen that referenced this pull request Aug 31, 2024
This reverts commit e393d91.

The generated files broke due to this change, so I'm rolling it
back.

Repro case is easy:

  go generate ./...
  go test ./...
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant