Skip to content

fix strict server returns wrong JSON for array responses#1165

Closed
const-tmp wants to merge 1 commit intooapi-codegen:mainfrom
const-tmp:fix-1147
Closed

fix strict server returns wrong JSON for array responses#1165
const-tmp wants to merge 1 commit intooapi-codegen:mainfrom
const-tmp:fix-1147

Conversation

@const-tmp
Copy link
Copy Markdown
Contributor

@const-tmp const-tmp commented Aug 1, 2023

Another attempt to fix #1147. Recreated #1148.
This time go generate ./... has been run. All tests pass.

New template function is added, which strips package name for external ref type.

@jamietanna jamietanna changed the title fix #1147 fix strict server returns wrong JSON for array responses Aug 29, 2023
@mromaszewicz
Copy link
Copy Markdown
Member

Thank you for contributing, and I'm very sorry for taking so long to get to this PR. At this point, the code has changed so much that it's no longer relevant because external reference handling was fixed via commit ad5eada ("Fix: Ensure external refs are propagated to generated code"). The strict response templates now properly handle external reference types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

strict server returns wrong JSON for array responses

2 participants