Fix: Generate models for all JSON media types#1177
Merged
jamietanna merged 1 commit intomasterfrom Aug 7, 2023
Merged
Conversation
As highlighted in #1168, we have some cases where JSON-compatible media types aren't having their respective models generated, as we previously only looked for `application/json`. To resolve this, we can make sure that any media types that are compatible with JSON (via our utility method) can have their types generated. This is a fix for #1168, which could also be deemed a feature. However, as this has broken in the upgrade from v1.12.x to v1.13.x, this is being treated as a feature. Closes #1168.
jamietanna
force-pushed
the
defect/all-json-types
branch
from
a0f2104 to
6df40d3
Compare
jamietanna
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As highlighted in #1168, we have some cases where JSON-compatible media
types aren't having their respective models generated, as we previously
only looked for
application/json.To resolve this, we can make sure that any media types that are
compatible with JSON (via our utility method) can have their types
generated.
This is a fix for #1168, which could also be deemed a feature. However,
as this has broken in the upgrade from v1.12.x to v1.13.x, this is being
treated as a feature.
Closes #1168.