AOCC Fails at constexpr check for MPI type

[yizeyi18]

Describe the bug

When compiling ABACUS using AOCC-4.1, error below occurs:

In file included from /home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/transfer.cpp:1:
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:157:35: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
    static constexpr MPI_Datatype datatype()
                                  ^
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:159:16: note: cast from 'void *' is not allowed in a constant expression
        return MPI_INT;
               ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:1188:17: note: expanded from macro 'MPI_INT'
#define MPI_INT OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_int)
                ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:400:47: note: expanded from macro 'OMPI_PREDEFINED_GLOBAL'
#define OMPI_PREDEFINED_GLOBAL(type, global) (static_cast<type> (static_cast<void *> (&(global))))
                                              ^
In file included from /home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/transfer.cpp:1:
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:166:35: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
    static constexpr MPI_Datatype datatype()
                                  ^
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:168:16: note: cast from 'void *' is not allowed in a constant expression
        return MPI_DOUBLE;
               ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:1191:20: note: expanded from macro 'MPI_DOUBLE'
#define MPI_DOUBLE OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_double)
                   ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:400:47: note: expanded from macro 'OMPI_PREDEFINED_GLOBAL'
#define OMPI_PREDEFINED_GLOBAL(type, global) (static_cast<type> (static_cast<void *> (&(global))))
                                              ^
In file included from /home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/transfer.cpp:1:
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:175:35: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
    static constexpr MPI_Datatype datatype()
                                  ^
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:177:16: note: cast from 'void *' is not allowed in a constant expression
        return MPI_DOUBLE_COMPLEX;
               ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:1266:28: note: expanded from macro 'MPI_DOUBLE_COMPLEX'
#define MPI_DOUBLE_COMPLEX OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_dblcplex)
                           ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:400:47: note: expanded from macro 'OMPI_PREDEFINED_GLOBAL'
#define OMPI_PREDEFINED_GLOBAL(type, global) (static_cast<type> (static_cast<void *> (&(global))))
                                              ^
[ 13%] Building CXX object source/module_base/CMakeFiles/base.dir/formatter_contextfmt.cpp.o
In file included from /home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/func_transfer.cpp:2:
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:157:35: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
    static constexpr MPI_Datatype datatype()
                                  ^
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:159:16: note: cast from 'void *' is not allowed in a constant expression
        return MPI_INT;
               ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:1188:17: note: expanded from macro 'MPI_INT'
#define MPI_INT OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_int)
                ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:400:47: note: expanded from macro 'OMPI_PREDEFINED_GLOBAL'
#define OMPI_PREDEFINED_GLOBAL(type, global) (static_cast<type> (static_cast<void *> (&(global))))
                                              ^
In file included from /home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/func_transfer.cpp:2:
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:166:35: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
    static constexpr MPI_Datatype datatype()
                                  ^
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:168:16: note: cast from 'void *' is not allowed in a constant expression
        return MPI_DOUBLE;
               ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:1191:20: note: expanded from macro 'MPI_DOUBLE'
#define MPI_DOUBLE OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_double)
                   ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:400:47: note: expanded from macro 'OMPI_PREDEFINED_GLOBAL'
#define OMPI_PREDEFINED_GLOBAL(type, global) (static_cast<type> (static_cast<void *> (&(global))))
                                              ^
In file included from /home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/func_transfer.cpp:2:
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:175:35: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
    static constexpr MPI_Datatype datatype()
                                  ^
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:177:16: note: cast from 'void *' is not allowed in a constant expression
        return MPI_DOUBLE_COMPLEX;
               ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:1266:28: note: expanded from macro 'MPI_DOUBLE_COMPLEX'
#define MPI_DOUBLE_COMPLEX OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_dblcplex)
                           ^
/home/yizeyi18/soft/spack/opt/spack/linux-ubuntu22.04-zen3/aocc-4.0.0/openmpi-4.1.5-tbilqgadlyp2c7z2zjeycbmascep3xfy/include/mpi.h:400:47: note: expanded from macro 'OMPI_PREDEFINED_GLOBAL'
#define OMPI_PREDEFINED_GLOBAL(type, global) (static_cast<type> (static_cast<void *> (&(global))))
                                              ^
3 errors generated.
make[2]: *** [source/module_hamilt_lcao/module_hcontainer/CMakeFiles/hcontainer.dir/build.make:146：source/module_hamilt_lcao/module_hcontainer/CMakeFiles/hcontainer.dir/transfer.cpp.o] 错误 1
make[2]: *** 正在等待未完成的任务....

Expected behavior

The code should pass compile.

To Reproduce

Build use AOCC-4.0 or 4.1.

Environment

OS: Ubuntu 22.04 LTS on linux-6.2.0-34-generic

Compiler: aocc-4.1

Dependencies: OpenBLAS-0.3.24, openmpi-4.1.5

Additional Context

This patch may fix, though breaks some safety check performed by the compiler:
aocc-mpi.patch

Task list for Issue attackers (only for developers)

• Verify the issue is not a duplicate.
• Describe the bug.
• Steps to reproduce.
• Expected behavior.
• Error message.
• Environment details.
• Additional context.
• Assign a priority level (low, medium, high, urgent).
• Assign the issue to a team member.
• Label the issue with relevant tags.
• Identify possible related issues.
• Create a unit test or automated test to reproduce the bug (if applicable).
• Fix the bug.
• Test the fix.
• Update documentation (if necessary).
• Close the issue and inform the reporter (if applicable).

[yizeyi18]

UPDATE：Clang-17.0.4 fails so.

[dyzheng]

Sorry, I don't have the background knowledge of this Issue, maybe other developers can help for this.

[yizeyi18]

Some further tests got done and it seems a little strange:
According to https://clang.llvm.org/cxx_status.html , clang should implemented constexpr cast from void* as part of c++2c standard in clang 17; the reality is, while enabling -DCMAKE_CXX_STANDARD=26(which adds -std=gnu++26 flag to clang), similar error still occurs:

Error message

In file included from /home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/transfer.cpp:1:
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:157:35: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
  157 |     static constexpr MPI_Datatype datatype()
      |                                   ^
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:159:16: note: cast from 'void *' is not allowed in a constant expression in C++ standards before C++2c
  159 |         return MPI_INT;
      |                ^
/opt/openmpi-4.1.5/include/mpi.h:1188:17: note: expanded from macro 'MPI_INT'
 1188 | #define MPI_INT OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_int)
      |                 ^
/opt/openmpi-4.1.5/include/mpi.h:400:47: note: expanded from macro 'OMPI_PREDEFINED_GLOBAL'
  400 | #define OMPI_PREDEFINED_GLOBAL(type, global) (static_cast<type> (static_cast<void *> (&(global))))
      |                                               ^
In file included from /home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/transfer.cpp:1:
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:166:35: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
  166 |     static constexpr MPI_Datatype datatype()
      |                                   ^
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:168:16: note: cast from 'void *' is not allowed in a constant expression in C++ standards before C++2c
  168 |         return MPI_DOUBLE;
      |                ^
/opt/openmpi-4.1.5/include/mpi.h:1191:20: note: expanded from macro 'MPI_DOUBLE'
 1191 | #define MPI_DOUBLE OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_double)
      |                    ^
/opt/openmpi-4.1.5/include/mpi.h:400:47: note: expanded from macro 'OMPI_PREDEFINED_GLOBAL'
  400 | #define OMPI_PREDEFINED_GLOBAL(type, global) (static_cast<type> (static_cast<void *> (&(global))))
      |                                               ^
In file included from /home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/transfer.cpp:1:
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:175:35: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
  175 |     static constexpr MPI_Datatype datatype()
      |                                   ^
/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:177:16: note: cast from 'void *' is not allowed in a constant expression in C++ standards before C++2c
  177 |         return MPI_DOUBLE_COMPLEX;
      |                ^
/opt/openmpi-4.1.5/include/mpi.h:1266:28: note: expanded from macro 'MPI_DOUBLE_COMPLEX'
 1266 | #define MPI_DOUBLE_COMPLEX OMPI_PREDEFINED_GLOBAL(MPI_Datatype, ompi_mpi_dblcplex)
      |                            ^
/opt/openmpi-4.1.5/include/mpi.h:400:47: note: expanded from macro 'OMPI_PREDEFINED_GLOBAL'
  400 | #define OMPI_PREDEFINED_GLOBAL(type, global) (static_cast<type> (static_cast<void *> (&(global))))
      |                                               ^

I had little idea why clang fails here.

EDIT:
Removing CMAKE_CXX_STANDARD in CMakeList.txt makes some difference, that clang gives some error message never seen before:

/home/yizeyi18/soft/abacus-develop-3.4.3/source/module_hamilt_lcao/module_hcontainer/./transfer.h:159:16: note: cast from 'void *' is not allowed in a constant expression because the pointed object type 'ompi_predefined_datatype_t' is not similar to the target type 'struct ompi_datatype_t'
  159 |         return MPI_INT;
      |                ^

That maybe hints the clang compiler really considers this cast as not good, though ompi_predefined_datatype_t contains only one ompi_datatype_t object and an array of char, and would fail here for this reason.

[denghuilu]

@yizeyi18, could you please verify the latest code in the development branch? Pull Request #3286 is expected to resolve this issue, particularly since the ROCm environment defaults to using the clang compiler. Check this.

[yizeyi18]

@yizeyi18, could you please verify the latest code in the development branch? Pull Request #3286 is expected to resolve this issue, particularly since the ROCm environment defaults to using the clang compiler. Check this.

constexpr totally removed...This solves. May we close this issue?