Skip to content

Stochastic DFT iter_header borrowed from Diagonalization ks_solver #7387

@Cstandardlib

Description

@Cstandardlib

Describe the Code Quality Issue

When performing sDFT computations without diagonalization, the SCF iter header is the same as KSDFT ks_solver:

// abacus-develop/source/source_estate/elecstate_print.cpp
    std::map<std::string, std::string> iter_header_dict
        = {{"cg", "CG"},
           {"cg_in_lcao", "CG"},
           {"lapack", "LA"},
           {"genelpa", "GE"},
           {"elpa", "EL"},
           {"dav", "DA"},
           {"dav_subspace", "DS"},
           {"scalapack_gvx", "GV"},
           {"cusolver", "CU"},
           {"bpcg", "BP"},
           {"pexsi", "PE"},
           {"cusolvermp", "CM"}}; 

Maybe the title should be changed into something else?

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Identify the specific code file or section with the code quality issue.
  • Investigate the issue and determine the root cause.
  • Research best practices and potential solutions for the identified issue.
  • Refactor the code to improve code quality, following the suggested solution.
  • Ensure the refactored code adheres to the project's coding standards.
  • Test the refactored code to ensure it functions as expected.
  • Update any relevant documentation, if necessary.
  • Submit a pull request with the refactored code and a description of the changes made.

Metadata

Metadata

Assignees

No one assigned

    Labels

    RefactorRefactor ABACUS codes

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions