Skip to content

How to recover the independence of module_orbital after moving in some parallel-code? #751

@maki49

Description

@maki49

The independence of module_orbital is destroyed after I tore down GlobalC::ParaO and moved some of its functions ( parallel-division of LCAO-basis ) into class ORB_control ( see PR #735 to TDDFT branch ).

Now I want to recover its independence after my refactor. I would to do following steps:

  • move all members of class ORB_control into module_orbitals/ORB_control.cpp
  • move src_parallel/parallel_orbitals.h, .cpp into module_orbitals/
  • move src_pdiag/pdiag_common.h, .cpp, src_parallel/parallel_common.h, .cpp into module_base or module_orbital
    • these two classes define MPI-interface and a struct LocalMatrix used in hpseps, so maybe moving them into module_base is better ?
  • finally, change all used GlobalC and GlobalV (such as ucell, ofs_running) in member functions of ORB_control into parameters.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions