Fix: Bug in EXX PW, nspin=2 due to wrong k-point index #6721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge with develop
This reverts commit d7b402d.
… s matrices no longer needed
Merge with upstream
Resolve conflict
Merge with latest
This reverts commit a8d71b2.
mohanchen
approved these changes
Nov 21, 2025
mohanchen
added
Bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a wrong k-point index, when nspin=2, EXX PW acts spin-down orbitals at spin-up orbitals, resulting in wrong results.
This PR also fixes bug that abacus crashes when kpar couldn't divide the number of k-points