Fix: Fix toolchain installation of Cereal#7116
Fix: Fix toolchain installation of Cereal#7116mohanchen merged 1 commit intodeepmodeling:developfrom
Conversation
|
Creating a CI/CD for the toolchain might be a good idea. |
There was a problem hiding this comment.
Pull request overview
This PR updates the ABACUS toolchain’s Cereal download source to match the fork already used by the CMake build logic, restoring the ability to apply the existing patch during toolchain installation.
Changes:
- Switch Cereal tarball download URLs from
USCiLab/cerealtoMCresearch/cereal. - Keep existing version/tag URL selection logic (branch names vs
v-prefixed tags).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Shut up |
|
@Flying-dragon-boxing Thanks for your fix! |
I'll check this out soon. Still, I think it's not a good idea that different routes for installing Cereal use different logics. |
It does compile with the upstream cereal after removing the patch |
mohanchen
added
Compile & CICD & Docs & Dependencies
Currently when installing Cereal using ABACUS toolchain, we apply a patch to Cereal's code in order to solve a compilation problem. The file where this patch apply has changed so the patch doesn't work any longer.
cmake/FindCereal.cmakeuses a forked version of Cereal (MCresearch/cereal), making the cereal version in ABACUS compilation stable. This PR applies the practice above to the toolchain.