Skip to content

2026PKUCourseHW5:verify output stream open in genelpa matrix save helpers#7175

Merged
mohanchen merged 1 commit intodeepmodeling:developfrom
chaomianpkp:fix/genelpa-check-ofstream-on-save
Mar 29, 2026
Merged

2026PKUCourseHW5:verify output stream open in genelpa matrix save helpers#7175
mohanchen merged 1 commit intodeepmodeling:developfrom
chaomianpkp:fix/genelpa-check-ofstream-on-save

Conversation

@chaomianpkp
Copy link
Copy Markdown

@chaomianpkp chaomianpkp commented Mar 28, 2026

  • saveLocalMatrix (real/complex) and saveMatrix (real/complex) now quit if open fails
  • Aligns error handling with loadMatrix

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

- saveLocalMatrix (real/complex) and saveMatrix (real/complex) now quit if open fails
- Aligns error handling with loadMatrix
Copy link
Copy Markdown
Collaborator

@mohanchen mohanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent contribution. I will accept it.

@mohanchen mohanchen added Refactor Refactor ABACUS codes Input&Output Suitable for coders without knowing too many DFT details labels Mar 29, 2026
@mohanchen mohanchen merged commit bf3fb24 into deepmodeling:develop Mar 29, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Input&Output Suitable for coders without knowing too many DFT details Refactor Refactor ABACUS codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants