Skip to content

Change threshold in 01_PW/208_PW_CG_float#7241

Merged
mohanchen merged 3 commits intodeepmodeling:developfrom
19hello:search_algorithm
Apr 17, 2026
Merged

Change threshold in 01_PW/208_PW_CG_float#7241
mohanchen merged 3 commits intodeepmodeling:developfrom
19hello:search_algorithm

Conversation

@19hello
Copy link
Copy Markdown
Collaborator

@19hello 19hello commented Apr 15, 2026

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

Copilot AI review requested due to automatic review settings April 15, 2026 06:00
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the per-case numerical tolerance for the single-precision (float) plane-wave CG integration test to better reflect expected precision limits in that configuration.

Changes:

  • Adjusted the threshold value for tests/01_PW/208_PW_CG_float from 1e-5 to 2e-5.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mohanchen mohanchen added Unit Tests/Integreate Tests Issues/PR related to unit tests and integrate tests Refactor Refactor ABACUS codes labels Apr 17, 2026
@mohanchen mohanchen merged commit 2145f9f into deepmodeling:develop Apr 17, 2026
19 checks passed
@mohanchen
Copy link
Copy Markdown
Collaborator

Fix #7233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Refactor ABACUS codes Unit Tests/Integreate Tests Issues/PR related to unit tests and integrate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants