Remove parameter.h include of files in source_base#7318
Merged
Conversation
Collaborator
Author
|
There are about 5 files left to work on after this PR |
mohanchen
added
Features Needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this PR:
Because modules in source_base is quite basic, so changing the function parameters directly will lead to a extremely huge change in the whole project.
So I added static variables, then injecting them when reading INPUT instead of directly using global variables or input parameters. In this way these files can get rid of having to include parameter.h to get the parameter.
About variables:
g_xxx means global_xxx
And the next PR is about global_file.cpp. It will affect a huge amount of files so it will not included in this PR.