perf(gint): optimize phi_operator kernels (Useful Information for some special optimization commands that have not been used in ABACUS before)#7366
Merged
Conversation
- set_phi_dphi_kernel: add WantPhi non-type template parameter and dispatch from the launch site. The dphi-only callers (gint_tau) pass phi=nullptr; with WantPhi==false the compiler drops the phi[] stores and the per-iw `phi != nullptr` branch entirely. - phi_dot_dphi_kernel / phi_dot_dphi_r_kernel: replace the shared- memory tree reduce with a single-warp warpReduceSum and drop the dynamic shared-memory allocation at the launch sites. Launch configuration is pinned at blockDim.x == 32; a comment guards the invariant. - Plain `if` (not `if constexpr`) on WantPhi keeps the code C++11-compliant — ABACUS targets C++11 and nvcc otherwise emits warning deepmodeling#2912-D. WantPhi is still a non-type template parameter, so the compiler folds the constant and eliminates the dead branch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mohanchen
approved these changes
May 21, 2026
mohanchen
added
Refactor
mohanchen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
phi_operator_gpu.cuandphi_operator_kernel.cu/.cuhto improve performance of the gint phi operator kernels.