Skip to content

Test: separate from #7304 for test cases only#7382

Merged
mohanchen merged 2 commits into
deepmodeling:developfrom
dyzheng:feat/tests-17-ds-dftu
May 25, 2026
Merged

Test: separate from #7304 for test cases only#7382
mohanchen merged 2 commits into
deepmodeling:developfrom
dyzheng:feat/tests-17-ds-dftu

Conversation

@dyzheng
Copy link
Copy Markdown
Collaborator

@dyzheng dyzheng commented May 25, 2026

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

Fix #...

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • Example: My changes might affect the performance of the application under certain conditions, and I have tested the impact on various scenarios...

Any changes of core modules? (ignore if not applicable)

  • Example: I have added a new virtual function in the esolver base class in order to ...

dyzheng added 2 commits May 25, 2026 10:39
Add the 17_DS_DFTU test suite for DeltaSpin and DFT+U functionality:
- 47 test cases covering LCAO/PW basis, collinear/noncollinear spin,
  DFT+U, DeltaSpin, and their combinations
- Comment out tests in tests/CMakeLists.txt and tests/17_DS_DFTU/CMakeLists.txt
  to prevent CI failure until DeltaSpin code is merged into develop
- Add single-line README to each test directory (printed during Autotest.sh)
- Rewrite CASES_CPU.txt with clear English comments explaining disabled tests
Copy link
Copy Markdown
Collaborator

@mohanchen mohanchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohanchen mohanchen added Tests/Examples Issues/PR related to unit tests and integrate tests Features Needed The features are indeed needed, and developers should have sophisticated knowledge DFT+U Issues related to DFT plus U function labels May 25, 2026
@mohanchen mohanchen merged commit 91c0c03 into deepmodeling:develop May 25, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DFT+U Issues related to DFT plus U function Features Needed The features are indeed needed, and developers should have sophisticated knowledge Tests/Examples Issues/PR related to unit tests and integrate tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants