Refactor: Remove obsolete cross-device copy constructor in HamiltPW#7418
Merged
Conversation
mohanchen
added
Refactor
mohanchen
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the unused cross-device copy constructor
HamiltPW(const HamiltPW<T_in, Device_in> *hamilt)and cleans up the associated dead code.Background:
This constructor was originally introduced in PR #1502 to facilitate the deep copying and conversion of Hamiltonian objects between CPU and GPU devices. However, following the comprehensive generic
<FPTYPE, Device>refactoring and the introduction of tensor-based memory synchronization in PR #1535, the eigensolvers no longer require direct cross-device casting of theHamiltPWobject. All calls to this constructor have already been removed.Changes:
HamiltPW::HamiltPW(const HamiltPW<T_in, Device_in> *hamilt)implementation inhamilt_pw.cpp.hamilt_pw.h.