Skip to content

ci: make Codecov upload non-blocking#5421

Merged
wanghan-iapcm merged 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/ci-make-codecov-upload-non-blocking
Apr 25, 2026
Merged

ci: make Codecov upload non-blocking#5421
wanghan-iapcm merged 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/ci-make-codecov-upload-non-blocking

Conversation

@njzjz-bot
Copy link
Copy Markdown
Contributor

@njzjz-bot njzjz-bot commented Apr 25, 2026

Summary

  • make the Codecov upload step non-blocking in test_cc.yml
  • make the Codecov upload step non-blocking in test_python.yml
  • keep coverage upload enabled while preventing transient Codecov/OIDC timeouts from failing otherwise successful test jobs

Why

A recent CI failure was caused by codecov/codecov-action@v6 failing to fetch an ID token (Failed to get ID Token / Request timeout) after the test steps had already passed. That makes the workflow red for an external upload hiccup rather than for an actual test regression.

This change keeps the upload for normal coverage reporting, but treats it as best-effort so flaky third-party upload issues do not block CI.

Validation

  • parsed both modified workflow files as YAML
  • ran git diff --check

Authored by OpenClaw (model: gpt-5.4)

Summary by CodeRabbit

  • Chores
    • Enhanced CI/CD pipeline reliability by making coverage upload failures non-blocking, ensuring tests continue to run successfully regardless of external service status.

Allow transient Codecov/OIDC upload failures without turning otherwise passing test jobs red.

Authored by OpenClaw (model: gpt-5.4)
@dosubot dosubot Bot added the build label Apr 25, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: bdf7c86e-bdcf-43b7-b25e-d0c4847cc3c6

📥 Commits

Reviewing files that changed from the base of the PR and between 5c22e17 and 6e6572e.

📒 Files selected for processing (2)
  • .github/workflows/test_cc.yml
  • .github/workflows/test_python.yml

📝 Walkthrough

Walkthrough

Two CI workflow files are modified to make Codecov coverage upload steps non-blocking by adding explicit step names and continue-on-error: true, preventing upload failures from failing the overall job while maintaining existing action configuration.

Changes

Cohort / File(s) Summary
GitHub Workflows - Codecov Step Configuration
.github/workflows/test_cc.yml, .github/workflows/test_python.yml
Made Codecov upload steps non-blocking by adding explicit step names ("Upload coverage to Codecov (non-blocking)") and continue-on-error: true, ensuring coverage upload failures don't fail the job while preserving existing action version and OIDC configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly summarizes the main change: making Codecov upload non-blocking in CI workflows. It matches the primary objective across both modified workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.45%. Comparing base (d42732e) to head (6e6572e).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5421      +/-   ##
==========================================
+ Coverage   80.35%   80.45%   +0.10%     
==========================================
  Files         819      823       +4     
  Lines       85445    86626    +1181     
  Branches     4139     4139              
==========================================
+ Hits        68661    69699    +1038     
- Misses      15508    15651     +143     
  Partials     1276     1276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes Codecov coverage uploads best-effort in the CI test workflows so transient Codecov/OIDC token timeouts don’t fail otherwise-successful test jobs.

Changes:

  • Update .github/workflows/test_python.yml to make the Codecov upload step non-blocking via continue-on-error: true.
  • Update .github/workflows/test_cc.yml to make the Codecov upload step non-blocking via continue-on-error: true.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/test_python.yml Marks the Codecov upload step as non-blocking while keeping OIDC-based upload enabled.
.github/workflows/test_cc.yml Marks the Codecov upload step as non-blocking while keeping OIDC-based upload enabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wanghan-iapcm wanghan-iapcm added this pull request to the merge queue Apr 25, 2026
Merged via the queue into deepmodeling:master with commit 6ec852d Apr 25, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants