test(lammps): skip spin DPA3 empty-subdomain pt2 case#5478
Conversation
Skip the spin DPA3 MPI empty-subdomain test while the with-comm AOTI artifact lacks an empty-local-atom fast path. The skipped test keeps a TODO pointing at the nloc_real == 0 divide-by-zero/SIGFPE follow-up. Authored by OpenClaw (model: custom-chat-jinzhezeng-group/gpt-5.5)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA pytest skip marker is added to the ChangesTest Skip Marker
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5478 +/- ##
==========================================
- Coverage 82.25% 82.25% -0.01%
==========================================
Files 833 833
Lines 89100 89099 -1
Branches 4225 4227 +2
==========================================
- Hits 73290 73289 -1
+ Misses 14518 14517 -1
- Partials 1292 1293 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wanghan-iapcm
left a comment
There was a problem hiding this comment.
check if pr #5485 solves this issue.
Problem
nloc_real == 0).Change
test_pair_deepmd_mpi_dpa3_spin_empty_subdomain.Notes
git diff --checkpassed.uv run pytest --collect-only -q source/lmp/tests/test_lammps_spin_dpa3_pt2.pyis blocked locally by the existing aarch64 uv dependency conflict betweenpin-jax-cpu(jax==0.10.0) andpin-jax-gpu(jax[cuda12]==0.5.0).Authored by OpenClaw (model: custom-chat-jinzhezeng-group/gpt-5.5)
Summary by CodeRabbit