refactor removing directory and provide asynchronous option #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation method removes files one by one using sftp. If the latency of the remote server is high, it is very slow. Thus, it's better to use system's `rm` to remove a directory, which may save a lot of time. Also, in some supercomputers, it's very slow to remove large numbers of files (e.g. directory containing trajectory) due to bad I/O performance. So an asynchronously option is provided. Implement deepmodeling/dpgen#385. Close deepmodeling/dpgen#385.
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 48.55% 48.64% +0.08%
==========================================
Files 20 20
Lines 1697 1694 -3
==========================================
Hits 824 824
+ Misses 873 870 -3
Continue to review full report at Codecov.
|
felix5572
approved these changes
May 26, 2021
njzjz
pushed a commit
to njzjz/dpdispatcher
that referenced
this pull request
Nov 4, 2025
fetch origin master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation method removes files one by one using sftp.
If the latency of the remote server is high, it is very slow.
Thus, it's better to use system's
rmto remove a directory, which maysave a lot of time.
Also, in some supercomputers, it's very slow to remove large numbers of files
(e.g. directory containing trajectory) due to bad I/O performance.
So an asynchronously option is provided.
Implement deepmodeling/dpgen#385. Close deepmodeling/dpgen#385.