remove a directory asynchronously #385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## devel #385 +/- ##
==========================================
+ Coverage 32.35% 32.37% +0.01%
==========================================
Files 85 85
Lines 14381 14373 -8
==========================================
Hits 4653 4653
+ Misses 9728 9720 -8
Continue to review full report at Codecov.
|
Member
|
Some times the user dose not want a asynchronous dir removing, we should provide the option for them. |
Member
Author
How do we provide the option? |
njzjz
added a commit
to njzjz/dpdispatcher
that referenced
this pull request
May 26, 2021
The original implementation method removes files one by one using sftp. If the latency of the remote server is high, it is very slow. Thus, it's better to use system's `rm` to remove a directory, which may save a lot of time. Also, in some supercomputers, it's very slow to remove large numbers of files (e.g. directory containing trajectory) due to bad I/O performance. So an asynchronously option is provided. Implement deepmodeling/dpgen#385. Close deepmodeling/dpgen#385.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation method removes files one by one.
In some supercomputers, it's very slow to remove large numbers of files
(e.g. directory containing trajectory) due to bad I/O performance.
Also, if the server latency is high, it is very terrible
to execute thousands of commands synchronously.
Instead, we can call
nohup rm -rf $directory >/dev/null &to remove a directory asynchronously, which will save a lot
of time in some situations.
@felix5572 said he may have a better way to implement it.