chore: remove fold_subdoc configurations to expose full schema#577
Merged
chore: remove fold_subdoc configurations to expose full schema#577
fold_subdoc configurations to expose full schema#577Conversation
Co-authored-by: njzjz <9496702+njzjz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove fold_subdoc configurations for schema visibility
Remove Feb 25, 2026
fold_subdoc configurations to expose full schema
njzjz
approved these changes
Feb 25, 2026
fold_subdoc configurations to expose full schemafold_subdoc configurations to expose full schema
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
==========================================
- Coverage 48.40% 48.35% -0.06%
==========================================
Files 40 40
Lines 3962 3958 -4
==========================================
- Hits 1918 1914 -4
Misses 2044 2044 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes fold_subdoc = True from the machine_args and resources_args argument schemas so that downstream schema/documentation consumers (including AI agents doing schema discovery) can see the full nested schema rather than a folded one-line summary.
Changes:
- Removed
fold_subdoc = Truefrommachine_argsandresources_argsin the PEP 723 metadata argument definition. - Removed
fold_subdoc = Truefrommachine_argsandresources_argsin the submission JSON argument definition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dpdispatcher/run.py | Exposes full nested schema for machine/resources in pep723_args() by removing subdoc folding. |
| dpdispatcher/entrypoints/submit.py | Exposes full nested schema for machine/resources in submission_args() by removing subdoc folding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fold_subdoc = Trueonmachine_argsandresources_argscollapsed sub-documentation into a single line, hiding the full argument schema from AI agents that rely on it for schema discovery.Changes
dpdispatcher/run.py(pep723_args): Removedfold_subdoc = Truefrommachine_argsandresources_argsdpdispatcher/entrypoints/submit.py(submission_args): Same removalsWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
39.106.xx.xx/home/REDACTED/work/dpdispatcher/dpdispatcher/.venv/bin/python python -m coverage run -p --source=./dpdispatcher -m unittest -v(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
fold_subdocconfigurations #576✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.