Skip to content

Conversation

@m1so
Copy link
Member

@m1so m1so commented Oct 31, 2025

Summary by CodeRabbit

  • Chores
    • Improved CI caching configuration to standardize cache keys and removal of legacy restore behavior, leading to more consistent and efficient builds and tests across the pipeline.

@linear
Copy link

linear bot commented Oct 31, 2025

BLU-5095 Fix flaky tests

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

📝 Walkthrough

Walkthrough

The PR updates the CI workflow cache steps: it removes restore-keys fallback blocks, renames cache key prefixes from venv-... to venv-v2-..., and standardizes the hash input to hashFiles('poetry.lock') (no ** glob). Spell-check, format, mypy, and tests-unit cache steps now use only their primary cache keys; other cache behavior and overall control flow remain unchanged.

Sequence Diagram(s)

sequenceDiagram
  participant Actions as GitHub Actions
  participant Cache as Actions Cache
  participant Job as CI Job

  Note over Actions,Job #F0F8FF: CI workflow starts
  Actions->>Cache: request cache(key: "venv-v2-<env>-<hash>")
  alt cache hit
    Cache-->>Actions: return cache archive
    Actions->>Job: restore dependencies from cache
  else cache miss
    Cache-->>Actions: no fallback (no restore-keys)
    Actions->>Job: install dependencies (resolve from lockfile)
  end
  Job->>Actions: run job steps (lint/test/mypy)
  Job->>Cache: save cache(key: "venv-v2-<env>-<hash>")
  Note over Actions,Cache #F0FFF0: hash uses hashFiles('poetry.lock')
Loading

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title accurately describes the primary change in the PR: removing restore-keys from the CI cache configuration. The rationale ("to always use latest lockfile") is stated clearly and matches the intent of the changeset. While the summary also mentions a cache key prefix update (venv-... to venv-v2-...), the title appropriately focuses on the main behavioral change without needing to cover every detail. The title is specific, concise, and avoids vague language.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4d245ed and b217074.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml (4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
  • GitHub Check: Typecheck - 3.11
  • GitHub Check: Test - Python 3.10
  • GitHub Check: Typecheck - 3.9
  • GitHub Check: Test - Python 3.12
  • GitHub Check: Spell Check
  • GitHub Check: Test - Python 3.9
  • GitHub Check: Test - Python 3.11
  • GitHub Check: Typecheck - 3.10
  • GitHub Check: Typecheck - 3.12
  • GitHub Check: Build and push artifacts for Python 3.10
  • GitHub Check: Build and push artifacts for Python 3.11
  • GitHub Check: Build and push artifacts for Python 3.12
  • GitHub Check: Build and push artifacts for Python 3.9
🔇 Additional comments (4)
.github/workflows/ci.yml (4)

45-50: Cache key updated for lockfile freshness.

Removal of restore-keys and bump to venv-v2- prefix aligns with the PR objective—every poetry.lock change invalidates the cache, ensuring latest dependencies are always installed.


81-86: Consistent cache strategy across jobs.

Format job cache follows the same pattern as spell-check. All dependency caches now enforce lockfile freshness uniformly.


182-187: Matrix-aware cache key generation.

Correctly uses matrix.python-version to create separate cache entries per Python version (3.9–3.12), maintaining cache isolation while enforcing lockfile freshness.


318-323: All dependency caches now aligned.

Tests-unit cache completes the uniform pattern across spell-check, format, mypy, and tests-unit jobs. Each invalidates independently on poetry.lock changes, preventing stale dependencies and addressing the flaky test root cause.

Warning

Tools execution failed with the following error:

Failed to run tools: 14 UNAVAILABLE: read ECONNRESET


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

📦 Python package built successfully!

  • Version: 1.0.0.dev4+533f32b
  • Wheel: deepnote_toolkit-1.0.0.dev4+533f32b-py3-none-any.whl
  • Install:
    pip install "deepnote-toolkit @ https://deepnote-staging-runtime-artifactory.s3.amazonaws.com/deepnote-toolkit-packages/1.0.0.dev4%2B533f32b/deepnote_toolkit-1.0.0.dev4%2B533f32b-py3-none-any.whl"

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (e2b6484) to head (b217074).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #15   +/-   ##
=======================================
  Coverage   76.60%   76.60%           
=======================================
  Files          99       99           
  Lines        5476     5476           
  Branches      748      748           
=======================================
  Hits         4195     4195           
  Misses       1281     1281           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai[bot]
coderabbitai bot previously approved these changes Oct 31, 2025
@deepnote-bot
Copy link

deepnote-bot commented Oct 31, 2025

🚀 Review App Deployment Started

📝 Description 🌐 Link / Info
🌍 Review application ra-15
🔑 Sign-in URL Click to sign-in
📊 Application logs View logs
🔄 Actions Click to redeploy
🚀 ArgoCD deployment View deployment
Last deployed 2025-10-31 18:35:28 (UTC)
📜 Deployed commit 62552543c69d520114d2d0a0477e750a5ea29797
🛠️ Toolkit version 533f32b

@m1so m1so marked this pull request as ready for review October 31, 2025 18:53
@m1so m1so requested a review from a team as a code owner October 31, 2025 18:53
@m1so m1so merged commit 4b1d15f into main Oct 31, 2025
31 checks passed
@m1so m1so deleted the michalbaumgartner/blu-5095-fix-flaky-tests branch October 31, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants