-
Notifications
You must be signed in to change notification settings - Fork 0
ci: add comprehensive lint and format checks to CI workflow #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add comprehensive lint and format checks to CI workflow #15
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
📝 WalkthroughWalkthroughA new CI job lint-and-format was added to .github/workflows/ci.yml. It runs on ubuntu-latest with a 15-minute timeout. The job performs: repository checkout (actions/checkout@v4), base setup (jupyterlab/maintainer-tools/.github/actions/base-setup@v1), installs Python dependencies (python -m pip install -U "jupyterlab>=4.0.0,<5"), installs Node dependencies using jlpm with GITHUB_TOKEN, and runs lint and format checks via jlpm run lint:check with GITHUB_TOKEN. Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Push/PR
participant GH as GitHub Actions
participant Job as Job: Lint & Format
participant Steps as Steps
Dev->>GH: Trigger workflow
GH->>Job: Start (ubuntu-latest, timeout 15m)
rect rgba(200,200,255,0.2)
Note over Job: Initialization
Job->>Steps: Checkout (actions/checkout@v4)
Steps-->>Job: Repo fetched
Job->>Steps: Base Setup (maintainer-tools base-setup@v1)
Steps-->>Job: Environment ready
end
rect rgba(200,255,200,0.2)
Note over Job: Dependencies
Job->>Steps: pip install "jupyterlab>=4.0.0,<5"
Steps-->>Job: Python deps installed
Job->>Steps: jlpm install (uses GITHUB_TOKEN)
Steps-->>Job: Node deps installed
end
rect rgba(255,240,200,0.2)
Note over Job: Checks
Job->>Steps: jlpm run lint:check (GITHUB_TOKEN)
Steps-->>Job: Lint/format results
end
Job-->>GH: Job complete (success/failure)
Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 18.50% 18.50%
=======================================
Files 13 13
Lines 200 200
Branches 27 27
=======================================
Hits 37 37
Misses 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ci: add comprehensive lint and format checks to CI workflow
Summary
Adds a new
lint-and-formatjob to the CI workflow that runs comprehensive code quality checks usingjlpm run lint:check. This job includes ESLint, Prettier, and stylelint checks to ensure code quality and consistent formatting across the codebase.The change addresses the requirement to have comprehensive linting and formatting checks in the CI workflow. Tests were intentionally left in the existing
build.ymlworkflow to avoid duplication.Review & Testing Checklist for Human
jlpm installjlpm run lint:checkcovers all expected tools (ESLint, Prettier, stylelint)Notes
build.ymlto avoid workflow duplicationSummary by CodeRabbit