Skip to content

chore(deps): update devdependencies (major) #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(deps): update devdependencies (major) #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,26 +78,26 @@
"@types/lodash": "^4.17.20",
"@types/react": "^18.0.26",
"@types/react-addons-linked-state-mixin": "^0.14.22",
"@typescript-eslint/eslint-plugin": "^6.1.0",
"@typescript-eslint/parser": "^6.1.0",
"css-loader": "^6.7.1",
"eslint": "^8.36.0",
"eslint-config-prettier": "^8.8.0",
"@typescript-eslint/eslint-plugin": "^8.0.0",
"@typescript-eslint/parser": "^8.0.0",
"css-loader": "^7.0.0",
"eslint": "^9.0.0",
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

ESLint 9 migration requires flat config—linting will break.

ESLint v9 removed support for package.json eslintConfig/eslintIgnore blocks. Your current config (lines 133–142) will be ignored; linting falls back to defaults.

Choose one:

  • Option A (preferred): Create eslint.config.js at repo root with flat config format. Migrate rules and ignores there, then remove legacy blocks from package.json.
  • Option B: Downgrade to "eslint": "^8.57.0" and keep legacy config.

This must be resolved before merge.

Also applies to: 133-142

🤖 Prompt for AI Agents 
package.json around line 84 (and legacy eslint blocks at lines 133–142): ESLint
v9 dropped package.json eslintConfig/eslintIgnore support so your current config
will be ignored; fix by either (A) creating an eslint.config.js at repo root
using the new flat config format, migrating all rules, parser/options, plugins
and ignore patterns from package.json to that file, remove the legacy
eslintConfig and eslintIgnore entries from package.json, and validate by running
eslint --print-config or a lint run; or (B) pin eslint back to a v8 release
(e.g. "eslint": "^8.57.0") in package.json to retain the legacy package.json
config — choose A (preferred) and remove the old blocks after migration.

"eslint-config-prettier": "^10.0.0",
Comment on lines +84 to +85
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

ESLint 9 breaks with legacy package.json config

ESLint v9 only reads flat configs; with the current "eslintConfig"/"eslintIgnore" blocks, eslint . now runs with defaults and misses all project rules. Either migrate to eslint.config.js (flat configs, move ignores there) or stay on ESLint 8.x for now.

Also applies to: 133-182

🤖 Prompt for AI Agents 
package.json lines 84-85 (and also lines 133-182) currently use the legacy
"eslintConfig"/"eslintIgnore" fields which ESLint v9 no longer supports; to fix,
either pin ESLint to the latest 8.x in package.json devDependencies (change
"eslint": "^9.0.0" to a compatible 8.x version and adjust lockfile) OR migrate
to the new flat config by adding an eslint.config.js at the project root
(convert existing settings from package.json "eslintConfig" into the flat config
format, move ignore patterns into an .eslintignore or into the new flat config
via overrides/ignores) and update any npm scripts that call eslint if needed;
apply the chosen approach consistently to the other package.json sections
referenced (lines 133-182).

"eslint-plugin-prettier": "^5.0.0",
"husky": "9.1.7",
"jest": "^29.2.0",
"jest": "^30.0.0",
"lint-staged": "16.2.3",
"mkdirp": "^1.0.3",
"npm-run-all2": "^7.0.1",
"mkdirp": "^3.0.0",
"npm-run-all2": "^8.0.0",
"prettier": "^3.0.0",
"rimraf": "^5.0.1",
"source-map-loader": "^1.0.2",
"style-loader": "^3.3.1",
"stylelint": "^15.10.1",
"stylelint-config-recommended": "^13.0.0",
"stylelint-config-standard": "^34.0.0",
"rimraf": "^6.0.0",
"source-map-loader": "^5.0.0",
"style-loader": "^4.0.0",
"stylelint": "^16.0.0",
"stylelint-config-recommended": "^17.0.0",
"stylelint-config-standard": "^39.0.0",
"stylelint-csstree-validator": "^3.0.0",
"stylelint-prettier": "^4.0.0",
"stylelint-prettier": "^5.0.0",
Comment on lines +81 to +100
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Lockfile must be regenerated after major version bumps.

Fifteen packages jumped majors (source-map-loader 1→5, mkdirp 1→3, @typescript-eslint 6→8, stylelint 15→16, etc.). No lockfile changes detected in this PR.

Required before merge:

  1. Run yarn install (or npm install) to regenerate yarn.lock/package-lock.json
  2. Run full CI locally: yarn clean:all && yarn install && yarn build && yarn lint && yarn test
  3. Commit updated lockfile and fix any breaking changes
  4. Verify no transitive dependency incompatibilities surface

Please confirm:

  • Lockfile was regenerated and committed
  • Full CI pipeline passes locally
  • Any breaking changes from major upgrades have been resolved

Generate a script to verify lockfile was updated:

🏁 Script executed:

#!/bin/bash
# Check if lockfile was modified in the last commit
echo "=== Checking if lockfile was regenerated ==="
git diff --name-only HEAD~1 | grep -E 'yarn\.lock|package-lock\.json' && echo "✓ Lockfile updated" || echo "✗ Lockfile NOT updated"

# Show the last few lines of the changed lockfile
echo -e "\n=== Recent lockfile changes (last 20 lines) ==="
git diff HEAD~1 yarn.lock 2>/dev/null | tail -20 || git diff HEAD~1 package-lock.json 2>/dev/null | tail -20 || echo "No lockfile diff found"

Length of output: 116

Lockfile not regenerated—blocking merge.

Verification confirms lockfile (yarn.lock/package-lock.json) was not updated despite 15 major version bumps. Regenerate lockfile and test:

yarn install && yarn clean:all && yarn install && yarn build && yarn lint && yarn test

Commit the updated lockfile before proceeding.

🤖 Prompt for AI Agents 
In package.json around lines 81–100 the dependency versions were bumped but the
lockfile was not regenerated; run the project's package manager to update the
lockfile (e.g., yarn install or npm install depending on repo), run the full
verification sequence provided (yarn install && yarn clean:all && yarn install
&& yarn build && yarn lint && yarn test), resolve any resulting
install/build/lint/test errors, and commit the updated lockfile (yarn.lock or
package-lock.json) alongside the change before merging.

"typescript": "~5.8.0",
"yjs": "^13.5.0"
},
Expand Down
Loading