Skip to content

Conversation

@mfranczel
Copy link
Member

@mfranczel mfranczel commented Oct 8, 2025

Summary by CodeRabbit

  • Chores
    • Renamed the published package to “deepnote-python-lsp-server.”
    • Update your dependency references (e.g., pip install, requirements.txt, pyproject) to the new name.
    • No functional or runtime changes; existing behavior remains the same.

@mfranczel mfranczel requested a review from m1so October 8, 2025 09:31
@linear
Copy link

linear bot commented Oct 8, 2025

@coderabbitai
Copy link

coderabbitai bot commented Oct 8, 2025

📝 Walkthrough

Walkthrough

The change updates the package’s published name from "python-lsp-server" to "deepnote-python-lsp-server". This is applied in two places: pyproject.toml ([project].name) and setup.py (setup(name=...)). No source code, configuration beyond naming, or runtime behavior is modified. Distribution metadata and install target are affected.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly reflects the core change by indicating a fix to the package name used for releases, which directly aligns with the modifications in both pyproject.toml and setup.py.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1618c7b and 419c624.

📒 Files selected for processing (2)
  • pyproject.toml (1 hunks)
  • setup.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Mac Py3.9
  • GitHub Check: Mac Py3.8
  • GitHub Check: Mac Py3.10
  • GitHub Check: Win Py3.10
  • GitHub Check: Win Py3.8
  • GitHub Check: Win Py3.9
  • GitHub Check: Linux Py3.10
  • GitHub Check: Linux Py3.9
  • GitHub Check: Linux Py3.8
🔇 Additional comments (1)
setup.py (1)

10-10: LGTM! Consistent with pyproject.toml.

Name change matches pyproject.toml. Comment clarifies purpose.

@mfranczel mfranczel merged commit bf2bf21 into develop Oct 8, 2025
1 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants